You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/11/10 17:24:23 UTC
[PR] Display auto_option hint in all cases [trafficserver]
JosiahWI opened a new pull request, #10762:
URL: https://github.com/apache/trafficserver/pull/10762
This takes the HINT added by @dragon512 a step further. The cases are as follows:
- feature enabled, option enabled: hints how to disable
- feature enabled, option disabled: no hint, something broke
- feature disabled, option enabled (AUTO): hints how to require
- feature disabled, option disabled: hints how to enable
I made a distinction between enabling and requiring. If the option is set to AUTO, it is already enabled, in some sense. If the user sets an option to ON, the user is requiring that the corresponding feature must be turned on, and should expect an error if a dependency is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Display auto_option hint in all cases [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #10762:
URL: https://github.com/apache/trafficserver/pull/10762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Display auto_option hint in all cases [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10762:
URL: https://github.com/apache/trafficserver/pull/10762#issuecomment-1808595298
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Display auto_option hint in all cases [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10762:
URL: https://github.com/apache/trafficserver/pull/10762#issuecomment-1812839680
[approve ci format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org