[jira] Commented: (CAMEL-1530) Upgrade camel-http to use httpclient 4.0

["Christian Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/activemq/browse/CAMEL-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56738#action_56738 ] 

Christian Mueller commented on CAMEL-1530:
------------------------------------------

@Oleg, after i read the httpclient documentation, the life is a little bit easier. :-)

With HttpProtocolParamBean and HttpConnectionParamBean I think we are able to configure 10 HTTP client parameter with the DI style and Camels type converter capabilities.

I think we can't use the method HttpProtocolParamBean.setVersion(HttpVersion), because HttpVersion is not a String or primitive. But we could contribute a HttpProtocolParamBean.setVersion(String) method, which accepts a string in the form "major.minor" like "1.1" and call the (new) method in HttpVersion.forVersion(String)
{code}
public class HttpProtocolParamBean extends HttpAbstractParamBean {
    
    public HttpProtocolParamBean (final HttpParams params) {
        super(params);
    }

    public void setVersion (final String version) {
        HttpProtocolParams.setVersion(params, HttpVersion.forVersion(version));
    }    
}
{code}

{code}
public final class HttpVersion extends ProtocolVersion
    implements Serializable {

    public ProtocolVersion forVersion(String version) {
        // parse string
        // set major and minor version
        forVersion(major, minor);
    }
}
{code}

But what is with the other 26 HTTP client params? Should/Could we contribute ParamBean's for these params to the httpclient project?

> Upgrade camel-http to use httpclient 4.0
> ----------------------------------------
>
>                 Key: CAMEL-1530
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1530
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-http
>    Affects Versions: 2.0-M1
>            Reporter: Claus Ibsen
>            Assignee: Christian Mueller
>             Fix For: 2.3.0
>
>
> Upgrading httpclient from 3.1 to 4.0 requires changes in the camel-http code as the API has change quite a lot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.