[jira] [Commented] (ARROW-2437) [C++] Change of arrow::ipc::ReadMessage signature breaks ABI compability

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431836#comment-16431836 ] 

ASF GitHub Bot commented on ARROW-2437:
---------------------------------------

robertnishihara opened a new pull request #1874: ARROW-2437: [C++] Add ReadMessage without aligned argument.
URL: https://github.com/apache/arrow/pull/1874
 
 
   cc @xhochy 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] Change of arrow::ipc::ReadMessage signature breaks ABI compability
> ------------------------------------------------------------------------
>
>                 Key: ARROW-2437
>                 URL: https://issues.apache.org/jira/browse/ARROW-2437
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Uwe L. Korn
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.1
>
>
> We changed the signature of the method from
> {code}
> ReadMessage ( arrow::io::InputStream* file, std::unique_ptr<message, std::default_delete<Message> >* message ) 
> {code}
> to
> {code}
> ReadMessage ( arrow::io::InputStream* file, std::unique_ptr<message, std::default_delete<Message> >* message, bool aligned ) 
> {code}
> We should add the old signature so that the 0.9.1 release is ABI compatible to 0.9.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)