You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2012/07/02 07:56:53 UTC
Review Request: cs-14907: download volume option should not be present to
volume in uploaded state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5692/
-----------------------------------------------------------
Review request for cloudstack and Brian Federle.
Description
-------
once volume is uploaded and when we try to download the same volume from the UI we'll get an error message saying :The volume doesnt belong to a storage pool so cant extract it
so basically ,a Volume can not be downloaded while it has not been moved to primary storage and upload volume just tries to bring the volume back to secondary storage . So download volume action should not be visible on the UI for volumes in uploaded state.Hence added a condition to solve this purpose.
This addresses bug CS-14907.
Diffs
-----
ui/scripts/storage.js 6f90d69
Diff: https://reviews.apache.org/r/5692/diff/
Testing
-------
Verfied on my cloudstack set up.
Thanks,
Pranav Saxena
Re: Review Request: cs-14907: download volume option should not be present
to volume in uploaded state
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5692/#review8806
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On July 2, 2012, 5:56 a.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5692/
> -----------------------------------------------------------
>
> (Updated July 2, 2012, 5:56 a.m.)
>
>
> Review request for cloudstack and Brian Federle.
>
>
> Description
> -------
>
> once volume is uploaded and when we try to download the same volume from the UI we'll get an error message saying :The volume doesnt belong to a storage pool so cant extract it
> so basically ,a Volume can not be downloaded while it has not been moved to primary storage and upload volume just tries to bring the volume back to secondary storage . So download volume action should not be visible on the UI for volumes in uploaded state.Hence added a condition to solve this purpose.
>
>
> This addresses bug CS-14907.
>
>
> Diffs
> -----
>
> ui/scripts/storage.js 6f90d69
>
> Diff: https://reviews.apache.org/r/5692/diff/
>
>
> Testing
> -------
>
> Verfied on my cloudstack set up.
>
>
> Thanks,
>
> Pranav Saxena
>
>