You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/14 16:17:05 UTC
[GitHub] [incubator-superset] etr2460 opened a new issue #11266: Type filter in Dataset CRUD view doesn't work
etr2460 opened a new issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266
When I select "Physical" as the dataset type I still get virtual datasets
### Expected results
Only get physical dataset types
### Actual results
Also get virtual datasets
#### Screenshots
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717599590
I think it's the later. The datasets seem to be correctly labeled as Virtual, but they still show up when you filter to Physical only datasets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-708553819
@etr2460 I'm not being able to reproduce this. The filter applies to `is_sqllab_view`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717354527
@dpgaspar, @nytai: I can still repro this, even with Presto datasources. However, it looks like the ones that get filtered as Physical but are labeled as Virtual have custom sql added to them. Perhaps that needs to be part of the filtering logic too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai closed issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai closed issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-708509146
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.95. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 edited a comment on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
etr2460 edited a comment on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717599590
I think it's the latter. The datasets seem to be correctly labeled as Virtual, but they still show up when you filter to Physical only datasets
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717641569
ok, I see what the discrepancy is here. The label of "Physical" and "Virtual" is based on the presence of the `sql` attribute (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset/connectors/base/models.py#L116). Meanwhile the filter for "Physical" and "Virtual" is based on the `is_sqllab_view` flag (see https://github.com/apache/incubator-superset/blob/155b5edec131d71eb392ee52f9bf97de495c2ef0/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx#L353).
So the question is, which attribute determines if it's a "virtual" dataset? The presence of the `sql` attribute or the `is_sqllab_view` attribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717643825
hmmm, looks like `is_sqllab_view` only exists for sqla datasources
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-708679902
I'm also unable to reproduce. @etr2460 are some of these datasets using the native druid connector? It's possible the [logic that determines the datasets type](https://github.com/preset-io/incubator-superset/blob/master/superset/connectors/base/models.py#L115) is incorrectly implemented for druid datasources. As @dpgaspar mentioned the actual filtering logic is applied to the `is_sqllab_view` attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-717384976
@etr2460 is the issue here that physical datasets are incorrectly labelled as virtual, or that the filter logic is not accounting for other instances/types of virtual datasets?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #11266: Type filter in Dataset CRUD view doesn't work
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #11266:
URL: https://github.com/apache/incubator-superset/issues/11266#issuecomment-718994431
@etr2460 can you confirm this was fixed by #11452 when you get a chance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org