You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2025/12/03 10:45:28 UTC
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23738
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
IMPALA-14580: Document Iceberg table repair functionality
Testing: built docs locally
Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
---
M docs/topics/impala_iceberg.xml
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/23738/1
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 1: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 13:33:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/844/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 14:20:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/844/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 14:14:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23738/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23738/1/docs/topics/impala_iceberg.xml@875
PS1, Line 875: <p>
: Impala can repair the table only if the missing files are data files,
: but it cannot repair the table if there are missing delete files.
: </p>
maybe this could be inside a <note>?
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:29:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 2: Code-Review+2
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 13:17:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/841/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 10:51:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23738/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/23738/1/docs/topics/impala_iceberg.xml@875
PS1, Line 875: <p>
: Impala can repair the table only if the missing files are data files,
: but it cannot repair the table if there are missing delete files.
: </p>
> maybe this could be inside a <note>?
instead of a <p>, similar to https://gerrit.cloudera.org/c/23738/1/docs/topics/impala_logging.xml#305
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Dec 2025 13:37:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/841/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 10:45:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Daniel Vanko (Code Review)" <ge...@cloudera.org>.
Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
Patch Set 2: Code-Review+1
LGTM, thank you!
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Dec 2025 13:05:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14580: Document Iceberg table repair functionality
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23738 )
Change subject: IMPALA-14580: Document Iceberg table repair functionality
......................................................................
IMPALA-14580: Document Iceberg table repair functionality
Testing: built docs locally
Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
---
M docs/topics/impala_iceberg.xml
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/23738/2
--
To view, visit http://gerrit.cloudera.org:8080/23738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67a861a56269648c5f8c2e9697861bf95587f731
Gerrit-Change-Number: 23738
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Vanko <dv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>