You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/05/01 14:44:30 UTC
[GitHub] [incubator-echarts-doc] alex2wong opened a new pull request #95: add new option 'nameProperty' in map series option
alex2wong opened a new pull request #95:
URL: https://github.com/apache/incubator-echarts-doc/pull/95
fix chinese doc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] alex2wong commented on a change in pull request #95: add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
alex2wong commented on a change in pull request #95:
URL: https://github.com/apache/incubator-echarts-doc/pull/95#discussion_r421212490
##########
File path: zh/option/component/geo-common.md
##########
@@ -89,6 +89,20 @@ boundingCoords: [
}
```
+#${prefix} nameProperty(string) = 'name'
+
+默认是 ’name‘，针对 GeoJSON 要素的自定义属性名称，作为主键用于关联数据点和 GeoJSON 地理要素。
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull request #95: add new option 'nameProperty' in map series option
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #95:
URL: https://github.com/apache/incubator-echarts-doc/pull/95#discussion_r421204406
##########
File path: zh/option/component/geo-common.md
##########
@@ -89,6 +89,20 @@ boundingCoords: [
}
```
+#${prefix} nameProperty(string) = 'name'
+
+默认是 ’name‘，针对 GeoJSON 要素的自定义属性名称，作为主键用于关联数据点和 GeoJSON 地理要素。
+例如：
+```js
+{
+ nameProperty: 'NAME', // 数据点中的 name：Alabama 会关联到 GeoJSON 中 NAME 属性值为 Alabama 的地理要素{"type":"Feature","id":"01","properties":{"NAME":"Alabama"}, "geometry": { ... }}
+ data:[
+ {name: 'Alabama', value: 4822023},
+ {name: 'Alaska', value: 731449},
+ ]
+}
+```
+
#${prefix} selectedMode(boolean|string) = false
Review comment:
The English doc seems to be wrong here with `#${prefix}` being `##`. Do you mind changing in this PR?
##########
File path: zh/option/component/geo-common.md
##########
@@ -89,6 +89,20 @@ boundingCoords: [
}
```
+#${prefix} nameProperty(string) = 'name'
+
+默认是 ’name‘，针对 GeoJSON 要素的自定义属性名称，作为主键用于关联数据点和 GeoJSON 地理要素。
Review comment:
’name‘ should be `'name'`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org