You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/03 21:22:25 UTC

[GitHub] [arrow] kou commented on a diff in pull request #35405: GH-35404: [Docs] Fix logo url and temporarily pin sphinx to 5.x to

kou commented on code in PR #35405:
URL: https://github.com/apache/arrow/pull/35405#discussion_r1184302179


##########
docs/source/_templates/docs-sidebar.html:
##########
@@ -1,6 +1,6 @@
 
 <a class="navbar-brand" href="{{ pathto(master_doc) }}">
-  <img src="{{ pathto('_static/' + logo_url, 1) }}" class="logo" alt="logo">
+  <img src="{{ logo_url|e }}" class="logo" alt="logo">

Review Comment:
   Does this work only with Sphinx 5?
   If this works with both of Sphinx 5 and 6, how about removing `,<6` for `sphinx` from this PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org