[GitHub] [skywalking] wu-sheng commented on a change in pull request #2840: Support exporter runs in increment and total modes

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #2840: Support exporter runs in increment and total modes
URL: https://github.com/apache/skywalking/pull/2840#discussion_r291810404
 
 

 ##########
 File path: oap-server/exporter/src/main/java/org/apache/skywalking/oap/server/exporter/provider/grpc/GRPCExporter.java
 ##########
 @@ -56,9 +56,15 @@ public GRPCExporter(GRPCExporterSetting setting) {
         subscriptionSet = new HashSet<>();
     }
 
-    @Override public void export(MetricsMetaInfo meta, Metrics metrics) {
-        if (subscriptionSet.size() == 0 || subscriptionSet.contains(meta.getMetricsName())) {
-            exportBuffer.produce(new ExportData(meta, metrics));
+    @Override public void export(ExportEvent event) {
+        if (ExportEvent.EventType.TOTAL.equals(event.getType())) {
 
 Review comment:
   I said this for `equal` PR, not merged. For enum, `==` is OK :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services