Re: cvs commit: apache/src CHANGES mod_userdir.c

[Randy Terbush <ra...@zyzzyva.com>]

> Now that we are starting to use a bugs database, it would be a Good
> Thing(tm) if you include a note saying "closes PR#666" in the commit
> message.  Then it would be cool to actually close it.  <g>

Yep. I made an attempt this morning, but got distracted before
I managed to remember my password....


> As you will see if you check out the audit trail for PR#28, I am in the
> habit of putting in what revision of the file it was fixed in.  
> 
> Example:
> 	State-Changed-From-To: analyzed-closed
> 	State-Changed-By: marc
> 	State-Changed-When: Sat Jan 25 12:22:29 PST 1997
> 	State-Changed-Why:
> 	Fixed in revision 1.13 of mod_userdir.c which will be
> 	in 1.2b5.
> 
> I think we really have to include the 1.2b5 bit, largely for the
> submitter since to them 1.13 means nothing and would confuse them, but
> I find the fixed in revision 1.13 to be quite handy.
> 
> On Sat, 25 Jan 1997, Randy Terbush wrote:
> 
> > randy       97/01/25 07:37:26
> > 
> >   Modified:    src       CHANGES mod_userdir.c
> >   Log:
> >   Allow * to terminate the end of a directory match in mod_dir.
> >   Allows /~* to match for both /~joe and /~joe/. [David Bronder]
> >   Reviewed by:	Alexei Kosut, Marc Slemko, Randy Terbush
> >   Submitted by: David Bronder <Da...@uiowa.edu>
> >   
> >   Revision  Changes    Path
> >   1.131     +3 -0      apache/src/CHANGES
> >   
> >   Index: CHANGES
> >   ===================================================================
> >   RCS file: /export/home/cvs/apache/src/CHANGES,v
> >   retrieving revision 1.130
> >   retrieving revision 1.131
> >   diff -C3 -r1.130 -r1.131
> >   *** CHANGES	1997/01/25 00:59:42	1.130
> >   --- CHANGES	1997/01/25 15:37:23	1.131
> >   ***************
> >   *** 1,5 ****
> >   --- 1,8 ----
> >     Changes with Apache 1.2b5
> >     
> >   +   *) Allow * to terminate the end of a directory match in mod_dir.
> >   +      Allows /~* to match for both /~joe and /~joe/. [David Bronder]
> >   + 
> >       *) Don't call can_exec() if suexec_enabled. Calling this requires
> >          scripts executed by the suexec wrapper to be world executable, which
> >          defeats one of the advantages of running the wrapper. [Randy Terbush]
> >   
> >   
> >   
> >   1.13      +2 -2      apache/src/mod_userdir.c
> >   
> >   Index: mod_userdir.c
> >   ===================================================================
> >   RCS file: /export/home/cvs/apache/src/mod_userdir.c,v
> >   retrieving revision 1.12
> >   retrieving revision 1.13
> >   diff -C3 -r1.12 -r1.13
> >   *** mod_userdir.c	1997/01/01 18:10:42	1.12
> >   --- mod_userdir.c	1997/01/25 15:37:24	1.13
> >   ***************
> >   *** 144,152 ****
> >     
> >     #ifdef __EMX__
> >           /* Add support for OS/2 drive letters */
> >   !       if ((userdir[0] == '/') || (userdir[1] == ':')) {
> >     #else
> >   !       if (userdir[0] == '/') {
> >     #endif
> >     	if (x) {
> >     	  if (strchr(x, ':')) {
> >   --- 144,152 ----
> >     
> >     #ifdef __EMX__
> >           /* Add support for OS/2 drive letters */
> >   !       if ((userdir[0] == '/') || (userdir[1] == ':') || (userdir[0] == '\0')) {
> >     #else
> >   !       if ((userdir[0] == '/') || (userdir[0] == '\0')) {
> >     #endif
> >     	if (x) {
> >     	  if (strchr(x, ':')) {
> >   
> >   
> >   
> >