You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/04 00:03:33 UTC
[GitHub] [spark] tedyu opened a new pull request #35394: Remove unnecessary null check for exception cause
tedyu opened a new pull request #35394:
URL: https://github.com/apache/spark/pull/35394
### What changes were proposed in this pull request?
In two classes under common/network-shuffle, we check whether t.getCause() is null before instanceof check.
The null check is not needed since null pointer wouldn't pass instanceof check.
### Why are the changes needed?
This PR simplifies the code by dropping unnecessary null check.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35394: Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35394:
URL: https://github.com/apache/spark/pull/35394#issuecomment-1029521760
That's fine; we normally mark these as [MINOR]. Any other instances?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #35394: [MINOR] Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #35394:
URL: https://github.com/apache/spark/pull/35394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tedyu commented on pull request #35394: [MINOR] Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
tedyu commented on pull request #35394:
URL: https://github.com/apache/spark/pull/35394#issuecomment-1029532716
I searched the code base but haven't found other instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tedyu commented on pull request #35394: Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
tedyu commented on pull request #35394:
URL: https://github.com/apache/spark/pull/35394#issuecomment-1029515570
cc @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #35394: [MINOR] Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #35394:
URL: https://github.com/apache/spark/pull/35394#issuecomment-1030110008
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tedyu commented on pull request #35394: [MINOR] Remove unnecessary null check for exception cause
Posted by GitBox <gi...@apache.org>.
tedyu commented on pull request #35394:
URL: https://github.com/apache/spark/pull/35394#issuecomment-1029580659
@srowen
All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org