You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/04/21 09:54:20 UTC

[GitHub] [pulsar] BewareMyPower opened a new pull request, #20163: [fix][client] Fix breaking changes for the deprecated methods of TopicMessageIdImpl

BewareMyPower opened a new pull request, #20163:
URL: https://github.com/apache/pulsar/pull/20163

   ### Motivation
   
   https://github.com/apache/pulsar/pull/19414 introduces a breaking change for the deprecated `TopicMessageIdImpl#getInnerMessageId` method. It does not return the inner message id, instead, it creates a new `MessageIdImpl`.
   
   ### Modifications
   
   Fix the `getInnerMessageId` method and add tests for these deprecated methods.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/BewareMyPower/pulsar/pull/28


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #20163: [fix][client] Fix breaking changes for the deprecated methods of TopicMessageIdImpl

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20163:
URL: https://github.com/apache/pulsar/pull/20163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org