You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/11/27 08:22:53 UTC

[GitHub] jerobi commented on issue #1532: hw/mcu/nordic/nrf52xxx: Revert sequence of operations for i2c errors

jerobi commented on issue #1532: hw/mcu/nordic/nrf52xxx: Revert sequence of operations for i2c errors
URL: https://github.com/apache/mynewt-core/pull/1532#issuecomment-441968174
 
 
   After further investigation, the issue was that on 1_5_0_dev
   regs->TASKS_STOP = 1;
   is being called on a successful write.
   
   By pushing the STOP inside the two error conditions, we are avoiding this errant STOP.
   
   I see that this has been fixed in a different way by returning zero ahead of the error label
   8055fb20ae993e15d293c4d95e01d4fe124c0ab3
   
   We will close our PR and instead cherry pick the change above into our code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services