You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jd...@apache.org on 2011/01/23 11:44:36 UTC
svn commit: r1062370 [4/4] - in /wicket/trunk/wicket-extensions/src:
main/java/org/apache/wicket/extensions/
main/java/org/apache/wicket/extensions/ajax/markup/html/
main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/
main/java/org/ap...
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/rating/RatingPanel.java Sun Jan 23 10:44:31 2011
@@ -102,13 +102,13 @@ public abstract class RatingPanel extend
/** For serialization. */
private static final long serialVersionUID = 1L;
- private RatingStarBar(String id, IModel<Integer> model)
+ private RatingStarBar(final String id, final IModel<Integer> model)
{
super(id, model);
}
@Override
- protected void populateItem(LoopItem item)
+ protected void populateItem(final LoopItem item)
{
// Use an AjaxFallbackLink for rating to make voting work even
// without Ajax.
@@ -117,7 +117,7 @@ public abstract class RatingPanel extend
private static final long serialVersionUID = 1L;
@Override
- public void onClick(AjaxRequestTarget target)
+ public void onClick(final AjaxRequestTarget target)
{
LoopItem item = (LoopItem)getParent();
@@ -196,7 +196,7 @@ public abstract class RatingPanel extend
* @param id
* the component id.
*/
- public RatingPanel(String id)
+ public RatingPanel(final String id)
{
this(id, null, 5, true);
}
@@ -209,7 +209,7 @@ public abstract class RatingPanel extend
* @param rating
* the model to get the rating
*/
- public RatingPanel(String id, IModel<? extends Number> rating)
+ public RatingPanel(final String id, final IModel<? extends Number> rating)
{
this(id, rating, new Model<Integer>(5), null, new Model<Boolean>(Boolean.FALSE), true);
}
@@ -223,7 +223,7 @@ public abstract class RatingPanel extend
* @param nrOfStars
* the number of stars to display
*/
- public RatingPanel(String id, int nrOfStars)
+ public RatingPanel(final String id, final int nrOfStars)
{
this(id, null, nrOfStars, true);
}
@@ -241,8 +241,8 @@ public abstract class RatingPanel extend
* @param addDefaultCssStyle
* should this component render its own default CSS style?
*/
- public RatingPanel(String id, IModel<? extends Number> rating, int nrOfStars,
- boolean addDefaultCssStyle)
+ public RatingPanel(final String id, final IModel<? extends Number> rating, final int nrOfStars,
+ final boolean addDefaultCssStyle)
{
this(id, rating, new Model<Integer>(nrOfStars), null, new Model<Boolean>(Boolean.FALSE),
addDefaultCssStyle);
@@ -264,8 +264,8 @@ public abstract class RatingPanel extend
* @param addDefaultCssStyle
* should this component render its own default CSS style?
*/
- public RatingPanel(String id, IModel<? extends Number> rating, int nrOfStars,
- IModel<Integer> nrOfVotes, boolean addDefaultCssStyle)
+ public RatingPanel(final String id, final IModel<? extends Number> rating, final int nrOfStars,
+ final IModel<Integer> nrOfVotes, final boolean addDefaultCssStyle)
{
this(id, rating, new Model<Integer>(nrOfStars), nrOfVotes,
new Model<Boolean>(Boolean.FALSE), addDefaultCssStyle);
@@ -289,8 +289,9 @@ public abstract class RatingPanel extend
* @param addDefaultCssStyle
* should this component render its own default CSS style?
*/
- public RatingPanel(String id, IModel<? extends Number> rating, IModel<Integer> nrOfStars,
- IModel<Integer> nrOfVotes, IModel<Boolean> hasVoted, boolean addDefaultCssStyle)
+ public RatingPanel(final String id, final IModel<? extends Number> rating,
+ final IModel<Integer> nrOfStars, final IModel<Integer> nrOfVotes,
+ final IModel<Boolean> hasVoted, final boolean addDefaultCssStyle)
{
super(id, rating);
this.addDefaultCssStyle = addDefaultCssStyle;
@@ -316,7 +317,7 @@ public abstract class RatingPanel extend
}
@Override
- public void renderHead(IHeaderResponse response)
+ public void renderHead(final IHeaderResponse response)
{
super.renderHead(response);
if (addDefaultCssStyle)
@@ -336,7 +337,7 @@ public abstract class RatingPanel extend
* the number of stars to generate
* @return the bar with rating stars
*/
- protected Component newRatingStarBar(String id, IModel<Integer> nrOfStars)
+ protected Component newRatingStarBar(final String id, final IModel<Integer> nrOfStars)
{
return new RatingStarBar(id, nrOfStars);
}
@@ -352,8 +353,8 @@ public abstract class RatingPanel extend
* the model containing the number of votes (may be null)
* @return the label component showing the message.
*/
- protected Component newRatingLabel(String id, IModel<? extends Number> rating,
- IModel<Integer> nrOfVotes)
+ protected Component newRatingLabel(final String id, final IModel<? extends Number> rating,
+ final IModel<Integer> nrOfVotes)
{
IModel<String> model;
if (nrOfVotes == null)
@@ -377,7 +378,7 @@ public abstract class RatingPanel extend
* the sequence number of the star
* @return the url pointing to the image for active stars.
*/
- protected String getActiveStarUrl(int iteration)
+ protected String getActiveStarUrl(final int iteration)
{
IRequestHandler handler = new ResourceReferenceRequestHandler(STAR1);
return getRequestCycle().urlFor(handler).toString();
@@ -391,7 +392,7 @@ public abstract class RatingPanel extend
* the sequence number of the star
* @return the url pointing to the image for inactive stars.
*/
- protected String getInactiveStarUrl(int iteration)
+ protected String getInactiveStarUrl(final int iteration)
{
IRequestHandler handler = new ResourceReferenceRequestHandler(STAR0);
return getRequestCycle().urlFor(handler).toString();
@@ -404,7 +405,7 @@ public abstract class RatingPanel extend
* true when the label should be visible
* @return this for chaining.
*/
- public RatingPanel setRatingLabelVisible(boolean visible)
+ public RatingPanel setRatingLabelVisible(final boolean visible)
{
ratingLabel.setVisible(visible);
return this;
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/util/encoding/CharSetMap.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/util/encoding/CharSetMap.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/util/encoding/CharSetMap.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/util/encoding/CharSetMap.java Sun Jan 23 10:44:31 2011
@@ -135,14 +135,14 @@ public final class CharSetMap
return createMap(input);
}
- private static Map<String, String> createMap(InputStream input) throws IOException
+ private static Map<String, String> createMap(final InputStream input) throws IOException
{
final Properties props = new Properties();
props.load(input);
return createMap(props);
}
- private static Map<String, String> createMap(Properties props)
+ private static Map<String, String> createMap(final Properties props)
{
HashMap<String, String> map = new HashMap<String, String>();
for (Object key : props.keySet())
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/validation/validator/RfcCompliantEmailAddressValidator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/validation/validator/RfcCompliantEmailAddressValidator.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/validation/validator/RfcCompliantEmailAddressValidator.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/validation/validator/RfcCompliantEmailAddressValidator.java Sun Jan 23 10:44:31 2011
@@ -147,7 +147,7 @@ public class RfcCompliantEmailAddressVal
* the <code>IValidatable</code> to check
*/
@Override
- protected Map<String, Object> variablesMap(IValidatable<String> validatable)
+ protected Map<String, Object> variablesMap(final IValidatable<String> validatable)
{
final Map<String, Object> map = super.variablesMap(validatable);
map.put("pattern", EMAIL_PATTERN);
@@ -155,7 +155,7 @@ public class RfcCompliantEmailAddressVal
}
@Override
- protected void onValidate(IValidatable<String> validatable)
+ protected void onValidate(final IValidatable<String> validatable)
{
String email = validatable.getValue().toString();
if (email.length() != email.trim().length())
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/AbstractWizardModel.java Sun Jan 23 10:44:31 2011
@@ -20,10 +20,10 @@ import java.util.ArrayList;
import java.util.List;
/**
- * Abstract wizard model that provides an implementation for handling
- * {@link IWizardModelListener wizard model listeners} and provides base implementations of many
- * methods. If you want to provide a custom implementation of {@link IWizardModel}, it is
- * recommended you start by overriding this class.
+ * Abstract wizard model that provides an implementation for handling {@link IWizardModelListener
+ * wizard model listeners} and provides base implementations of many methods. If you want to provide
+ * a custom implementation of {@link IWizardModel}, it is recommended you start by overriding this
+ * class.
*
* @author eelcohillenius
*/
@@ -58,14 +58,14 @@ public abstract class AbstractWizardMode
* @param listener
* The listener to add
*/
- public final void addListener(IWizardModelListener listener)
+ public final void addListener(final IWizardModelListener listener)
{
wizardModelListeners.add(listener);
}
/**
- * This implementation just fires {@link IWizardModelListener#onCancel() a cancel event}.
- * Though this isn't a very strong contract, it gives all the power to the user of this model.
+ * This implementation just fires {@link IWizardModelListener#onCancel() a cancel event}. Though
+ * this isn't a very strong contract, it gives all the power to the user of this model.
*
* @see IWizardModel#cancel()
*/
@@ -75,8 +75,8 @@ public abstract class AbstractWizardMode
}
/**
- * This implementation just fires {@link IWizardModelListener#onFinish() a finish event}.
- * Though this isn't a very strong contract, it gives all the power to the user of this model.
+ * This implementation just fires {@link IWizardModelListener#onFinish() a finish event}. Though
+ * this isn't a very strong contract, it gives all the power to the user of this model.
*
* @see IWizardModel#finish()
*/
@@ -113,7 +113,7 @@ public abstract class AbstractWizardMode
* @param listener
* The listener to remove
*/
- public final void removeListener(IWizardModelListener listener)
+ public final void removeListener(final IWizardModelListener listener)
{
wizardModelListeners.remove(listener);
}
@@ -124,7 +124,7 @@ public abstract class AbstractWizardMode
* @param cancelVisible
* Whether cancel functionality is available
*/
- public void setCancelVisible(boolean cancelVisible)
+ public void setCancelVisible(final boolean cancelVisible)
{
this.cancelVisible = cancelVisible;
}
@@ -136,7 +136,7 @@ public abstract class AbstractWizardMode
* <tt>true</tt> to display the last button, <tt>false</tt> otherwise.
* @see #isLastVisible
*/
- public void setLastVisible(boolean lastVisible)
+ public void setLastVisible(final boolean lastVisible)
{
this.lastVisible = lastVisible;
}
@@ -147,7 +147,7 @@ public abstract class AbstractWizardMode
* @param step
* The new step
*/
- protected final void fireActiveStepChanged(IWizardStep step)
+ protected final void fireActiveStepChanged(final IWizardStep step)
{
for (IWizardModelListener listener : wizardModelListeners)
{
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/CancelButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/CancelButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/CancelButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/CancelButton.java Sun Jan 23 10:44:31 2011
@@ -34,7 +34,7 @@ public class CancelButton extends Wizard
* @param wizard
* The wizard
*/
- public CancelButton(String id, IWizard wizard)
+ public CancelButton(final String id, final IWizard wizard)
{
super(id, wizard, "org.apache.wicket.extensions.wizard.cancel");
setDefaultFormProcessing(false);
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/FinishButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/FinishButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/FinishButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/FinishButton.java Sun Jan 23 10:44:31 2011
@@ -34,7 +34,7 @@ public class FinishButton extends Wizard
* @param wizard
* The wizard
*/
- public FinishButton(String id, IWizard wizard)
+ public FinishButton(final String id, final IWizard wizard)
{
super(id, wizard, "org.apache.wicket.extensions.wizard.finish");
}
@@ -46,7 +46,7 @@ public class FinishButton extends Wizard
public boolean isEnabled()
{
IWizardStep activeStep = getWizardModel().getActiveStep();
- return (activeStep != null && getWizardModel().isLastStep(activeStep));
+ return ((activeStep != null) && getWizardModel().isLastStep(activeStep));
}
/**
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizard.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizard.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizard.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizard.java Sun Jan 23 10:44:31 2011
@@ -20,8 +20,8 @@ import org.apache.wicket.IClusterable;
/**
* Interface for the wizard component. This interface is here for ultimate flexibility, though it
- * doesn't guarantee much. Typically, you would extend from
- * {@link Wizard the default wizard component} instead of implementing this interface directly.
+ * doesn't guarantee much. Typically, you would extend from {@link Wizard the default wizard
+ * component} instead of implementing this interface directly.
*
* <p>
* Part of the contract of wizards is that {@link IWizardStep wizard steps} are initialized when the
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/IWizardModel.java Sun Jan 23 10:44:31 2011
@@ -28,14 +28,14 @@ import org.apache.wicket.IClusterable;
*
* <p>
* {@link IWizardModelListener wizard model listeners} can be registered to be notified of important
- * events (changing the active step) using the
- * {@link #addListener(IWizardModelListener) add listener} method.
+ * events (changing the active step) using the {@link #addListener(IWizardModelListener) add
+ * listener} method.
* </p>
*
* <p>
- * Typically, you would use {@link WizardModel the default implementation of this interface}, but
- * if you need to do more sophisticated stuff, like branching etc, you can consider creating your
- * own implementation. In that case, it is recommended you start by extending from
+ * Typically, you would use {@link WizardModel the default implementation of this interface}, but if
+ * you need to do more sophisticated stuff, like branching etc, you can consider creating your own
+ * implementation. In that case, it is recommended you start by extending from
* {@link AbstractWizardModel}.
* </p>
*
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/LastButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/LastButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/LastButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/LastButton.java Sun Jan 23 10:44:31 2011
@@ -35,7 +35,7 @@ public class LastButton extends WizardBu
* @param wizard
* The wizard
*/
- public LastButton(String id, IWizard wizard)
+ public LastButton(final String id, final IWizard wizard)
{
super(id, wizard, "org.apache.wicket.extensions.wizard.last");
}
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/NextButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/NextButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/NextButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/NextButton.java Sun Jan 23 10:44:31 2011
@@ -34,7 +34,7 @@ public class NextButton extends WizardBu
* @param id
* @param wizard
*/
- public NextButton(String id, IWizard wizard)
+ public NextButton(final String id, final IWizard wizard)
{
super(id, wizard, "org.apache.wicket.extensions.wizard.next");
}
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/PreviousButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/PreviousButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/PreviousButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/PreviousButton.java Sun Jan 23 10:44:31 2011
@@ -34,7 +34,7 @@ public class PreviousButton extends Wiza
* @param wizard
* The wizard
*/
- public PreviousButton(String id, IWizard wizard)
+ public PreviousButton(final String id, final IWizard wizard)
{
super(id, wizard, "org.apache.wicket.extensions.wizard.previous");
setDefaultFormProcessing(false);
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/StaticContentStep.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/StaticContentStep.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/StaticContentStep.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/StaticContentStep.java Sun Jan 23 10:44:31 2011
@@ -44,7 +44,7 @@ public class StaticContentStep extends W
* If true, any html of the content will be rendered as is. Otherwise, it will be
* escaped.
*/
- public StaticContentStep(boolean allowHtml)
+ public StaticContentStep(final boolean allowHtml)
{
this.allowHtml = allowHtml;
add(new Label("content", ""));
@@ -63,8 +63,8 @@ public class StaticContentStep extends W
* If true, any html of the content will be rendered as is. Otherwise, it will be
* escaped.
*/
- public StaticContentStep(IModel<String> title, IModel<String> summary, IModel<?> content,
- boolean allowHtml)
+ public StaticContentStep(final IModel<String> title, final IModel<String> summary,
+ final IModel<?> content, final boolean allowHtml)
{
super(title, summary);
this.content = content;
@@ -85,8 +85,8 @@ public class StaticContentStep extends W
* If true, any html of the content will be rendered as is. Otherwise, it will be
* escaped.
*/
- public StaticContentStep(IModel<String> title, IModel<String> summary, String content,
- boolean allowHtml)
+ public StaticContentStep(final IModel<String> title, final IModel<String> summary,
+ final String content, final boolean allowHtml)
{
this(title, summary, new Model<String>(content), allowHtml);
}
@@ -104,7 +104,8 @@ public class StaticContentStep extends W
* If true, any html of the content will be rendered as is. Otherwise, it will be
* escaped.
*/
- public StaticContentStep(String title, String summary, IModel<?> content, boolean allowHtml)
+ public StaticContentStep(final String title, final String summary, final IModel<?> content,
+ final boolean allowHtml)
{
this(new Model<String>(title), new Model<String>(summary), content, allowHtml);
}
@@ -122,7 +123,8 @@ public class StaticContentStep extends W
* If true, any html of the content will be rendered as is. Otherwise, it will be
* escaped.
*/
- public StaticContentStep(String title, String summary, String content, boolean allowHtml)
+ public StaticContentStep(final String title, final String summary, final String content,
+ final boolean allowHtml)
{
this(title, summary, new Model<String>(content), allowHtml);
}
@@ -166,7 +168,7 @@ public class StaticContentStep extends W
* @param content
* The content model
*/
- public final <T> void setContentModel(IModel<T> content)
+ public final <T> void setContentModel(final IModel<T> content)
{
this.content = content;
replace(new Label("content", content).setEscapeModelStrings(!allowHtml));
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/Wizard.java Sun Jan 23 10:44:31 2011
@@ -96,7 +96,7 @@ public class Wizard extends Panel implem
* @param id
* The component model
*/
- public Wizard(String id)
+ public Wizard(final String id)
{
this(id, true);
}
@@ -117,7 +117,7 @@ public class Wizard extends Panel implem
* @param addDefaultCssStyle
* Whether to add the {@link #addDefaultCssStyle() default style}
*/
- public Wizard(String id, boolean addDefaultCssStyle)
+ public Wizard(final String id, final boolean addDefaultCssStyle)
{
super(id);
this.addDefaultCssStyle = addDefaultCssStyle;
@@ -134,7 +134,7 @@ public class Wizard extends Panel implem
* @param wizardModel
* The transitions model
*/
- public Wizard(String id, IWizardModel wizardModel)
+ public Wizard(final String id, final IWizardModel wizardModel)
{
this(id, wizardModel, true);
}
@@ -152,7 +152,7 @@ public class Wizard extends Panel implem
* @param addDefaultCssStyle
* Whether to add the {@link #addDefaultCssStyle() default style}
*/
- public Wizard(String id, IWizardModel wizardModel, boolean addDefaultCssStyle)
+ public Wizard(final String id, final IWizardModel wizardModel, final boolean addDefaultCssStyle)
{
super(id);
@@ -165,13 +165,13 @@ public class Wizard extends Panel implem
* Will let the wizard contribute a CSS include to the page's header. It will add Wizard.css
* from this package. This method is typically called by the class that creates the wizard.
*/
- public void addDefaultCssStyle(IHeaderResponse response)
+ public void addDefaultCssStyle(final IHeaderResponse response)
{
response.renderCSSReference(new PackageResourceReference(Wizard.class, "Wizard.css"));
}
@Override
- public void renderHead(IHeaderResponse response)
+ public void renderHead(final IHeaderResponse response)
{
super.renderHead(response);
if (addDefaultCssStyle)
@@ -224,7 +224,7 @@ public class Wizard extends Panel implem
/**
* @see org.apache.wicket.extensions.wizard.IWizardModelListener#onActiveStepChanged(org.apache.wicket.extensions.wizard.IWizardStep)
*/
- public void onActiveStepChanged(IWizardStep newStep)
+ public void onActiveStepChanged(final IWizardStep newStep)
{
form.replace(newStep.getView(VIEW_ID, this, this));
form.replace(newStep.getHeader(HEADER_ID, this, this));
@@ -253,7 +253,7 @@ public class Wizard extends Panel implem
*
* @param wizardModel
*/
- protected void init(IWizardModel wizardModel)
+ protected void init(final IWizardModel wizardModel)
{
if (wizardModel == null)
{
@@ -295,7 +295,7 @@ public class Wizard extends Panel implem
*
* @return A new button bar
*/
- protected Component newButtonBar(String id)
+ protected Component newButtonBar(final String id)
{
return new WizardButtonBar(id, this);
}
@@ -309,7 +309,7 @@ public class Wizard extends Panel implem
*
* @return A new feedback panel
*/
- protected FeedbackPanel newFeedbackPanel(String id)
+ protected FeedbackPanel newFeedbackPanel(final String id)
{
return new FeedbackPanel(id, new ContainerFeedbackMessageFilter(this));
}
@@ -324,7 +324,7 @@ public class Wizard extends Panel implem
* The id to be used to construct the component
* @return a new form
*/
- protected <E> Form<E> newForm(String id)
+ protected <E> Form<E> newForm(final String id)
{
return new Form<E>(id);
}
@@ -349,7 +349,7 @@ public class Wizard extends Panel implem
*
* @return A new overview bar
*/
- protected Component newOverviewBar(String id)
+ protected Component newOverviewBar(final String id)
{
// return a dummy component by default as we don't have an overview
// component
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButton.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButton.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButton.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButton.java Sun Jan 23 10:44:31 2011
@@ -48,7 +48,7 @@ public abstract class WizardButton exten
* @param labelResourceKey
* The resource key of the button's label
*/
- public WizardButton(String id, IWizard wizard, String labelResourceKey)
+ public WizardButton(final String id, final IWizard wizard, final String labelResourceKey)
{
super(id, new ResourceModel(labelResourceKey));
this.wizard = wizard;
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButtonBar.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButtonBar.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButtonBar.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardButtonBar.java Sun Jan 23 10:44:31 2011
@@ -25,9 +25,9 @@ import org.apache.wicket.markup.html.pan
* not, override {@link Wizard#newButtonBar(String)} and provide your own.
* <p>
* The button bar holds the {@link PreviousButton previous}, [@link NextButton next},
- * {@link LastButton last}, [@link CancelButton cancel} and {@link FinishButton finish} buttons.
- * The {@link LastButton last button} is off by default. You can turn it on by having the wizard
- * model return true for {@link IWizardModel#isLastVisible() the is last visible method}.
+ * {@link LastButton last}, [@link CancelButton cancel} and {@link FinishButton finish} buttons. The
+ * {@link LastButton last button} is off by default. You can turn it on by having the wizard model
+ * return true for {@link IWizardModel#isLastVisible() the is last visible method}.
* </p>
*
* @author Eelco Hillenius
@@ -44,7 +44,7 @@ public class WizardButtonBar extends Pan
* @param wizard
* The containing wizard
*/
- public WizardButtonBar(String id, Wizard wizard)
+ public WizardButtonBar(final String id, final Wizard wizard)
{
super(id);
add(new PreviousButton("previous", wizard));
@@ -57,7 +57,7 @@ public class WizardButtonBar extends Pan
/**
* @see org.apache.wicket.extensions.wizard.IDefaultButtonProvider#getDefaultButton(org.apache.wicket.extensions.wizard.IWizardModel)
*/
- public IFormSubmittingComponent getDefaultButton(IWizardModel model)
+ public IFormSubmittingComponent getDefaultButton(final IWizardModel model)
{
if (model.isNextAvailable())
{
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardModel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardModel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardModel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardModel.java Sun Jan 23 10:44:31 2011
@@ -105,12 +105,16 @@ public class WizardModel extends Abstrac
* @param step
* the step to added.
*/
- public void add(IWizardStep step)
+ public void add(final IWizardStep step)
{
if (step instanceof ICondition)
+ {
add(step, (ICondition)step);
+ }
else
+ {
add(step, TRUE);
+ }
}
/**
@@ -122,7 +126,7 @@ public class WizardModel extends Abstrac
* @param condition
* the {@link ICondition} under which it should be included in the wizard.
*/
- public void add(IWizardStep step, ICondition condition)
+ public void add(final IWizardStep step, final ICondition condition)
{
steps.add(step);
conditions.add(condition);
@@ -152,7 +156,7 @@ public class WizardModel extends Abstrac
/**
* @see org.apache.wicket.extensions.wizard.IWizardModel#isLastStep(org.apache.wicket.extensions.wizard.IWizardStep)
*/
- public boolean isLastStep(IWizardStep step)
+ public boolean isLastStep(final IWizardStep step)
{
return findLastStep().equals(step);
}
@@ -222,9 +226,9 @@ public class WizardModel extends Abstrac
* @param step
* the new active step step.
*/
- public void setActiveStep(IWizardStep step)
+ public void setActiveStep(final IWizardStep step)
{
- if (activeStep != null && step != null && activeStep.equals(step))
+ if ((activeStep != null) && (step != null) && activeStep.equals(step))
{
return;
}
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardStep.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardStep.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardStep.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/WizardStep.java Sun Jan 23 10:44:31 2011
@@ -114,7 +114,7 @@ public class WizardStep extends Panel im
* @param validator
* The validator to add
*/
- public final void add(IFormValidator validator)
+ public final void add(final IFormValidator validator)
{
validators.add(validator);
}
@@ -144,7 +144,7 @@ public class WizardStep extends Panel im
/**
* @see org.apache.wicket.markup.html.form.validation.IFormValidator#validate(org.apache.wicket.markup.html.form.Form)
*/
- public void validate(Form<?> form)
+ public void validate(final Form<?> form)
{
if (isActiveStep())
{
@@ -251,7 +251,7 @@ public class WizardStep extends Panel im
* @param summary
* a brief summary of this step or some usage guidelines.
*/
- public WizardStep(IModel<String> title, IModel<String> summary)
+ public WizardStep(final IModel<String> title, final IModel<String> summary)
{
this(title, summary, null);
}
@@ -267,7 +267,8 @@ public class WizardStep extends Panel im
* @param model
* Any model which is to be used for this step
*/
- public WizardStep(IModel<String> title, IModel<String> summary, IModel<?> model)
+ public WizardStep(final IModel<String> title, final IModel<String> summary,
+ final IModel<?> model)
{
super(Wizard.VIEW_ID, model);
@@ -284,7 +285,7 @@ public class WizardStep extends Panel im
* @param summary
* a brief summary of this step or some usage guidelines.
*/
- public WizardStep(String title, String summary)
+ public WizardStep(final String title, final String summary)
{
this(title, summary, null);
}
@@ -300,7 +301,7 @@ public class WizardStep extends Panel im
* @param model
* Any model which is to be used for this step
*/
- public WizardStep(String title, String summary, IModel<?> model)
+ public WizardStep(final String title, final String summary, final IModel<?> model)
{
this(new Model<String>(title), new Model<String>(summary), model);
}
@@ -310,7 +311,7 @@ public class WizardStep extends Panel im
*
* @param validator
*/
- public final void add(IFormValidator validator)
+ public final void add(final IFormValidator validator)
{
if (onAttachAction == null)
{
@@ -330,7 +331,7 @@ public class WizardStep extends Panel im
* @see org.apache.wicket.extensions.wizard.IWizardStep#getHeader(java.lang.String,
* org.apache.wicket.Component, org.apache.wicket.extensions.wizard.IWizard)
*/
- public Component getHeader(String id, Component parent, IWizard wizard)
+ public Component getHeader(final String id, final Component parent, final IWizard wizard)
{
return new Header(id, wizard);
}
@@ -361,7 +362,7 @@ public class WizardStep extends Panel im
* @see org.apache.wicket.extensions.wizard.IWizardStep#getView(java.lang.String,
* org.apache.wicket.Component, org.apache.wicket.extensions.wizard.IWizard)
*/
- public Component getView(String id, Component parent, IWizard wizard)
+ public Component getView(final String id, final Component parent, final IWizard wizard)
{
return this;
}
@@ -383,7 +384,7 @@ public class WizardStep extends Panel im
* @param wizardModel
* the model to which the step belongs.
*/
- public final void init(IWizardModel wizardModel)
+ public final void init(final IWizardModel wizardModel)
{
this.wizardModel = wizardModel;
onInit(wizardModel);
@@ -410,7 +411,7 @@ public class WizardStep extends Panel im
* <tt>true</tt> to allow the wizard to proceed, <tt>false</tt> otherwise.
* @see #isComplete
*/
- public void setComplete(boolean complete)
+ public void setComplete(final boolean complete)
{
this.complete = complete;
}
@@ -421,7 +422,7 @@ public class WizardStep extends Panel im
* @param summary
* summary
*/
- public void setSummaryModel(IModel<String> summary)
+ public void setSummaryModel(final IModel<String> summary)
{
this.summary = wrap(summary);
}
@@ -432,7 +433,7 @@ public class WizardStep extends Panel im
* @param title
* title
*/
- public void setTitleModel(IModel<String> title)
+ public void setTitleModel(final IModel<String> title)
{
this.title = wrap(title);
}
@@ -476,7 +477,7 @@ public class WizardStep extends Panel im
* @param wizardModel
* @see #init(IWizardModel)
*/
- protected void onInit(IWizardModel wizardModel)
+ protected void onInit(final IWizardModel wizardModel)
{
}
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardModel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardModel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardModel.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardModel.java Sun Jan 23 10:44:31 2011
@@ -49,7 +49,7 @@ public class DynamicWizardModel extends
* @param startStep
* first step in the wizard
*/
- public DynamicWizardModel(IDynamicWizardStep startStep)
+ public DynamicWizardModel(final IDynamicWizardStep startStep)
{
this.startStep = startStep;
}
@@ -82,7 +82,7 @@ public class DynamicWizardModel extends
/**
* @see org.apache.wicket.extensions.wizard.IWizardModel#isLastStep(org.apache.wicket.extensions.wizard.IWizardStep)
*/
- public boolean isLastStep(IWizardStep step)
+ public boolean isLastStep(final IWizardStep step)
{
return ((IDynamicWizardStep)step).isLastStep();
}
@@ -149,7 +149,7 @@ public class DynamicWizardModel extends
* @param step
* the new active step step.
*/
- protected final void setActiveStep(IDynamicWizardStep step)
+ protected final void setActiveStep(final IDynamicWizardStep step)
{
if (step == null)
{
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardStep.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardStep.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardStep.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/DynamicWizardStep.java Sun Jan 23 10:44:31 2011
@@ -39,7 +39,7 @@ public abstract class DynamicWizardStep
* @param previousStep
* The previous step. May be null if this is the first step in the wizard
*/
- public DynamicWizardStep(IDynamicWizardStep previousStep)
+ public DynamicWizardStep(final IDynamicWizardStep previousStep)
{
super();
this.previousStep = previousStep;
@@ -56,8 +56,8 @@ public abstract class DynamicWizardStep
* @param summary
* a brief summary of this step or some usage guidelines.
*/
- public DynamicWizardStep(IDynamicWizardStep previousStep, IModel<String> title,
- IModel<String> summary)
+ public DynamicWizardStep(final IDynamicWizardStep previousStep, final IModel<String> title,
+ final IModel<String> summary)
{
super(title, summary);
this.previousStep = previousStep;
@@ -76,8 +76,8 @@ public abstract class DynamicWizardStep
* @param model
* Any model which is to be used for this step
*/
- public DynamicWizardStep(IDynamicWizardStep previousStep, IModel<String> title,
- IModel<String> summary, IModel<?> model)
+ public DynamicWizardStep(final IDynamicWizardStep previousStep, final IModel<String> title,
+ final IModel<String> summary, final IModel<?> model)
{
super(title, summary, model);
this.previousStep = previousStep;
@@ -94,7 +94,8 @@ public abstract class DynamicWizardStep
* @param summary
* a brief summary of this step or some usage guidelines.
*/
- public DynamicWizardStep(IDynamicWizardStep previousStep, String title, String summary)
+ public DynamicWizardStep(final IDynamicWizardStep previousStep, final String title,
+ final String summary)
{
super(title, summary);
this.previousStep = previousStep;
@@ -113,8 +114,8 @@ public abstract class DynamicWizardStep
* @param model
* Any model which is to be used for this step
*/
- public DynamicWizardStep(IDynamicWizardStep previousStep, String title, String summary,
- IModel<?> model)
+ public DynamicWizardStep(final IDynamicWizardStep previousStep, final String title,
+ final String summary, final IModel<?> model)
{
super(title, summary, model);
this.previousStep = previousStep;
Modified: wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/IDynamicWizardStep.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/IDynamicWizardStep.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/IDynamicWizardStep.java (original)
+++ wicket/trunk/wicket-extensions/src/main/java/org/apache/wicket/extensions/wizard/dynamic/IDynamicWizardStep.java Sun Jan 23 10:44:31 2011
@@ -80,8 +80,8 @@ public interface IDynamicWizardStep exte
* Gets the next wizard step from here. Can only be called when {@link #isNextAvailable()}
* returns true.
*
- * @return The next wizard step. May not be null unless this is the last step ({@link #isLastStep()}
- * returns true).
+ * @return The next wizard step. May not be null unless this is the last step (
+ * {@link #isLastStep()} returns true).
*/
IDynamicWizardStep next();
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/WicketTestCase.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/WicketTestCase.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/WicketTestCase.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/WicketTestCase.java Sun Jan 23 10:44:31 2011
@@ -79,7 +79,7 @@ public abstract class WicketTestCase ext
* @throws Exception
*/
protected <T extends Page> void executeTest(final Class<T> pageClass,
- PageParameters parameters, final String filename) throws Exception
+ final PageParameters parameters, final String filename) throws Exception
{
System.out.println("=== " + pageClass.getName() + " ===");
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabelPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabelPage.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabelPage.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableLabelPage.java Sun Jan 23 10:44:31 2011
@@ -41,7 +41,7 @@ public class AjaxEditableLabelPage exten
private static final long serialVersionUID = 1L;
@Override
- public void onClick(AjaxRequestTarget target)
+ public void onClick(final AjaxRequestTarget target)
{
ajaxLabel.setEnabled(!ajaxLabel.isEnabled());
target.add(ajaxLabel);
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableTest.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableTest.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/ajax/markup/html/AjaxEditableTest.java Sun Jan 23 10:44:31 2011
@@ -42,7 +42,7 @@ public class AjaxEditableTest extends Wi
/**
* Tests default AjaxEditableLabel behavior
*/
- @SuppressWarnings({"unchecked"})
+ @SuppressWarnings({ "unchecked" })
public void testAjaxEditableLabel()
{
Page page = tester.getLastRenderedPage();
@@ -70,7 +70,7 @@ public class AjaxEditableTest extends Wi
* Tests whether disabling/enabling an AjaxEditableLabel also disables/enables the
* <code>LabelBehavior</code>
*/
- @SuppressWarnings({"unchecked"})
+ @SuppressWarnings({ "unchecked" })
public void testDisabledAjaxEditableLabel()
{
Page page = tester.getLastRenderedPage();
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/AjaxLazyLoadPanelTesterTest.java Sun Jan 23 10:44:31 2011
@@ -44,14 +44,14 @@ public class AjaxLazyLoadPanelTesterTest
{
private static final long serialVersionUID = 1L;
- public Panel getTestPanel(String panelId)
+ public Panel getTestPanel(final String panelId)
{
return new AjaxLazyLoadPanel(panelId)
{
private static final long serialVersionUID = 1L;
@Override
- public Component getLazyLoadComponent(String markupId)
+ public Component getLazyLoadComponent(final String markupId)
{
return new Label(markupId, "lazy panel test").setRenderBodyOnly(true);
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/Contact.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/Contact.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/Contact.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/Contact.java Sun Jan 23 10:44:31 2011
@@ -58,7 +58,7 @@ public class Contact implements ICluster
* @see java.lang.Object#equals(java.lang.Object)
*/
@Override
- public boolean equals(Object obj)
+ public boolean equals(final Object obj)
{
if (obj == this)
{
@@ -86,7 +86,7 @@ public class Contact implements ICluster
/**
* @param id
*/
- public void setId(long id)
+ public void setId(final long id)
{
this.id = id;
}
@@ -105,7 +105,7 @@ public class Contact implements ICluster
* @param firstName
* @param lastName
*/
- public Contact(String firstName, String lastName)
+ public Contact(final String firstName, final String lastName)
{
this.firstName = firstName;
this.lastName = lastName;
@@ -122,7 +122,7 @@ public class Contact implements ICluster
/**
* @param cellPhone
*/
- public void setCellPhone(String cellPhone)
+ public void setCellPhone(final String cellPhone)
{
this.cellPhone = cellPhone;
}
@@ -138,7 +138,7 @@ public class Contact implements ICluster
/**
* @param firstName
*/
- public void setFirstName(String firstName)
+ public void setFirstName(final String firstName)
{
this.firstName = firstName;
}
@@ -154,7 +154,7 @@ public class Contact implements ICluster
/**
* @param homePhone
*/
- public void setHomePhone(String homePhone)
+ public void setHomePhone(final String homePhone)
{
this.homePhone = homePhone;
}
@@ -170,7 +170,7 @@ public class Contact implements ICluster
/**
* @param lastName
*/
- public void setLastName(String lastName)
+ public void setLastName(final String lastName)
{
this.lastName = lastName;
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactGenerator.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactGenerator.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactGenerator.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactGenerator.java Sun Jan 23 10:44:31 2011
@@ -80,7 +80,7 @@ public class ContactGenerator
* @param collection
* @param count
*/
- public void generate(Collection<Contact> collection, int count)
+ public void generate(final Collection<Contact> collection, final int count)
{
for (int i = 0; i < count; i++)
{
@@ -101,12 +101,12 @@ public class ContactGenerator
.toString();
}
- private int rint(int min, int max)
+ private int rint(final int min, final int max)
{
return (int)(Math.random() * (max - min) + min);
}
- private String randomString(String[] choices)
+ private String randomString(final String[] choices)
{
return choices[rint(0, choices.length)];
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactsDatabase.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactsDatabase.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactsDatabase.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/ContactsDatabase.java Sun Jan 23 10:44:31 2011
@@ -45,7 +45,7 @@ public class ContactsDatabase
* @param count
* number of contacts to generate at startup
*/
- public ContactsDatabase(int count)
+ public ContactsDatabase(final int count)
{
for (int i = 0; i < count; i++)
{
@@ -60,7 +60,7 @@ public class ContactsDatabase
* @param id
* @return contact
*/
- public Contact get(long id)
+ public Contact get(final long id)
{
Contact c = map.get(id);
if (c == null)
@@ -87,12 +87,12 @@ public class ContactsDatabase
* @param sort
* @return list of contacts
*/
- public List<Contact> find(int first, int count, SortParam sort)
+ public List<Contact> find(final int first, final int count, final SortParam sort)
{
return getIndex(sort).subList(first, first + count);
}
- protected List<Contact> getIndex(SortParam sort)
+ protected List<Contact> getIndex(final SortParam sort)
{
if (sort == null)
{
@@ -108,7 +108,8 @@ public class ContactsDatabase
{
return sort.isAscending() ? lnameIdx : lnameDescIdx;
}
- throw new RuntimeException("unknown sort option [" + sort + "]. valid fields: [firstName], [lastName]");
+ throw new RuntimeException("unknown sort option [" + sort +
+ "]. valid fields: [firstName], [lastName]");
}
/**
@@ -160,7 +161,7 @@ public class ContactsDatabase
{
Collections.sort(fnameIdx, new Comparator<Contact>()
{
- public int compare(Contact arg0, Contact arg1)
+ public int compare(final Contact arg0, final Contact arg1)
{
return (arg0).getFirstName().compareTo((arg1).getFirstName());
}
@@ -168,7 +169,7 @@ public class ContactsDatabase
Collections.sort(lnameIdx, new Comparator<Contact>()
{
- public int compare(Contact arg0, Contact arg1)
+ public int compare(final Contact arg0, final Contact arg1)
{
return (arg0).getLastName().compareTo((arg1).getLastName());
}
@@ -176,7 +177,7 @@ public class ContactsDatabase
Collections.sort(fnameDescIdx, new Comparator<Contact>()
{
- public int compare(Contact arg0, Contact arg1)
+ public int compare(final Contact arg0, final Contact arg1)
{
return (arg1).getFirstName().compareTo((arg0).getFirstName());
}
@@ -184,7 +185,7 @@ public class ContactsDatabase
Collections.sort(lnameDescIdx, new Comparator<Contact>()
{
- public int compare(Contact arg0, Contact arg1)
+ public int compare(final Contact arg0, final Contact arg1)
{
return (arg1).getLastName().compareTo((arg0).getLastName());
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTablePage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTablePage.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTablePage.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DataTablePage.java Sun Jan 23 10:44:31 2011
@@ -47,8 +47,8 @@ public class DataTablePage extends WebPa
{
private static final long serialVersionUID = 1L;
- public void populateItem(Item<ICellPopulator<Contact>> cellItem, String componentId,
- IModel<Contact> rowModel)
+ public void populateItem(final Item<ICellPopulator<Contact>> cellItem,
+ final String componentId, final IModel<Contact> rowModel)
{
cellItem.add(new WebMarkupContainer(componentId, rowModel));
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DetachableContactModel.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DetachableContactModel.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DetachableContactModel.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/DetachableContactModel.java Sun Jan 23 10:44:31 2011
@@ -38,7 +38,7 @@ public class DetachableContactModel exte
/**
* @param c
*/
- public DetachableContactModel(Contact c)
+ public DetachableContactModel(final Contact c)
{
this(c.getId());
}
@@ -46,7 +46,7 @@ public class DetachableContactModel exte
/**
* @param id
*/
- public DetachableContactModel(long id)
+ public DetachableContactModel(final long id)
{
if (id == 0)
{
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/SortableContactDataProvider.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/SortableContactDataProvider.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/SortableContactDataProvider.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/repeater/data/table/SortableContactDataProvider.java Sun Jan 23 10:44:31 2011
@@ -50,7 +50,7 @@ public class SortableContactDataProvider
/**
* @see org.apache.wicket.markup.repeater.data.IDataProvider#iterator(int, int)
*/
- public Iterator<Contact> iterator(int first, int count)
+ public Iterator<Contact> iterator(final int first, final int count)
{
return getContactsDB().find(first, count, getSort()).iterator();
}
@@ -66,7 +66,7 @@ public class SortableContactDataProvider
/**
* @see org.apache.wicket.markup.repeater.data.IDataProvider#model(java.lang.Object)
*/
- public IModel<Contact> model(Contact object)
+ public IModel<Contact> model(final Contact object)
{
return new DetachableContactModel(object);
}
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/tree/MoveChildToParentNodeMarkedForRecreationTestPage.java Sun Jan 23 10:44:31 2011
@@ -41,7 +41,7 @@ public class MoveChildToParentNodeMarked
private static final long serialVersionUID = 1L;
@Override
- public void onClick(AjaxRequestTarget target)
+ public void onClick(final AjaxRequestTarget target)
{
treeTable.modelChanging();
DefaultTreeModel model = (DefaultTreeModel)treeTable.getDefaultModelObject();
Modified: wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/upload/UploadFormWithProgressBarTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/upload/UploadFormWithProgressBarTest.java?rev=1062370&r1=1062369&r2=1062370&view=diff
==============================================================================
--- wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/upload/UploadFormWithProgressBarTest.java (original)
+++ wicket/trunk/wicket-extensions/src/test/java/org/apache/wicket/extensions/markup/html/upload/UploadFormWithProgressBarTest.java Sun Jan 23 10:44:31 2011
@@ -73,8 +73,8 @@ public class UploadFormWithProgressBarTe
form.add(new UploadProgressBar("progress", form));
}
- public IResourceStream getMarkupResourceStream(MarkupContainer container,
- Class<?> containerClass)
+ public IResourceStream getMarkupResourceStream(final MarkupContainer container,
+ final Class<?> containerClass)
{
return new StringResourceStream(
"<html><body><a wicket:id=\"re-create\"></a>"
@@ -85,10 +85,10 @@ public class UploadFormWithProgressBarTe
}
public static class TraceableForm extends Form
{
- private int formInstance;
+ private final int formInstance;
private static int nextInstanceId;
- public TraceableForm(String id)
+ public TraceableForm(final String id)
{
super(id);
formInstance = nextInstanceId++;