You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/22 07:31:07 UTC
[GitHub] [skywalking] wu-sheng opened a new issue, #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
wu-sheng opened a new issue, #10000:
URL: https://github.com/apache/skywalking/issues/10000
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
@wankai123 enhanced our Zipkin support in past months. Ref doc, https://skywalking.apache.org/docs/main/next/en/setup/backend/zipkin-trace/
Now, we are more confident to work as an alternative server for people who wants their Zipkin traces to stay side by side with other metrics/logs in an all-in-one APM.
@Fine0830 The lens UI source codes are here, https://github.com/openzipkin/zipkin/tree/master/zipkin-lens. It is a very lightweight UI component, I am considering we could bundle them in our distribution, and you could wrap it as a widget to let the dashboard host it on a tab page.
### Use case
@wankai123 could help you to set up test env for testing.
@Fine0830 There is no feature change requirement. You need to decide whether we should copy/paste those codes, which may be helpful if we need to bump up dependencies to fix CVE or expired libs.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
URL: https://github.com/apache/skywalking/issues/10000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1369494549
@kezhenxu94 Let's leverage the latest UI widget and bring Zipkin Lens UI into the Service Mesh dashboard. And consider opening Zipkin tracing in Istio of Showcase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1323365631
@tacigar told me there are several enhancements he wants to land on the code base,
- https://github.com/openzipkin/zipkin/pull/3348
- https://github.com/openzipkin/zipkin/pull/3349
- https://github.com/openzipkin/zipkin/pull/3350
They are tested and used for a private distribution. We should adopt those too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1371974311
@wu-sheng did you expect to put the Zipkin UI here?
<img width="704" alt="image" src="https://user-images.githubusercontent.com/15965696/210745755-73db53a1-6f11-479d-958f-b29cfa3168e6.png">
What should users see in this tab if they enable SkyWalking Envoy tracer? They would be confused why the trace tab is showing Zipkin since they enable SkyWalking tracer.
Also, I don't think Zipkin is tightly bound to `Service Mesh` so there is no point to put it under that menu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1371976305
We need a place to show this. And only service mesh is the case showing the trace and doesn't rely on trace analysis.
That is why I ask for putting in here.
And the tab should be `Zipkin Trace`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
URL: https://github.com/apache/skywalking/issues/10000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1365715226
The one last step is to wait for @Fine0830 to provide a new kind of widget, which could host the Zipkin lens UI on an isolated iFramework. This widget would work separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10000: [Feature] [Zipkin UI] Bundle Zipkin Lens UI in our distribution as a widget component
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #10000:
URL: https://github.com/apache/skywalking/issues/10000#issuecomment-1323229865
Notice, if we are going to copy them, we should keep their license headers, and put the statement in the LICENSE and NOTICE files of source codes and binary, as we are doing re-distribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org