[GitHub] [maven-mvnd] ppalaga commented on issue #842: NPE during expiration check

["ppalaga (via GitHub)" <gi...@apache.org>]

ppalaga commented on issue #842:
URL: https://github.com/apache/maven-mvnd/issues/842#issuecomment-1538490862

   First a `null` strategy is a legit outcome of the code around here 
   
   https://github.com/apache/maven-mvnd/blob/a15abc25dfea50cf1479307a2ac0af2db7730f68/daemon/src/main/java/org/mvndaemon/mvnd/daemon/DaemonMemoryStatus.java#L110-L142
   
   So isTrashing, isHeapSpaceExhausted & friends should not assume strategy being non-null
   
   https://github.com/apache/maven-mvnd/blob/a15abc25dfea50cf1479307a2ac0af2db7730f68/daemon/src/main/java/org/mvndaemon/mvnd/daemon/DaemonMemoryStatus.java#L162-L171
   
   Would you mind sending a PR?
   
   Second, I wonder what GcStrategy params would catch your JVM `Java version: 11.0.18, vendor: IBM Corporation, runtime: /home/user/.sdkman/candidates/java/11.0.18-sem`? 
   
   https://github.com/apache/maven-mvnd/blob/a15abc25dfea50cf1479307a2ac0af2db7730f68/daemon/src/main/java/org/mvndaemon/mvnd/daemon/DaemonMemoryStatus.java#L49-L53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org