You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "feiniaofeiafei (via GitHub)" <gi...@apache.org> on 2025/04/30 09:13:52 UTC
[PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
feiniaofeiafei opened a new pull request, #50573:
URL: https://github.com/apache/doris/pull/50573
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2841420792
<details>
<summary>TPC-DS: <b>Total hot run time: 185529 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 88580ea453cb81838042e5bcc1bc3abfd91a7977, data reload: false
query1 1007 466 493 466
query2 6567 1780 1790 1780
query3 6750 222 216 216
query4 26670 23601 23328 23328
query5 4317 640 451 451
query6 304 198 224 198
query7 4632 493 280 280
query8 304 243 245 243
query9 8627 2552 2552 2552
query10 491 355 272 272
query11 15745 15075 14854 14854
query12 168 111 109 109
query13 1667 525 392 392
query14 9405 6205 6252 6205
query15 194 183 168 168
query16 7243 671 491 491
query17 1179 721 611 611
query18 1978 397 279 279
query19 190 191 156 156
query20 124 113 112 112
query21 208 128 115 115
query22 4139 4109 3914 3914
query23 33845 33000 32942 32942
query24 8441 2382 2389 2382
query25 560 453 376 376
query26 1244 266 151 151
query27 2761 504 326 326
query28 4351 2075 2062 2062
query29 752 543 427 427
query30 281 217 195 195
query31 930 884 779 779
query32 76 64 63 63
query33 553 368 315 315
query34 793 838 520 520
query35 787 814 744 744
query36 953 999 888 888
query37 117 101 79 79
query38 4169 4067 4132 4067
query39 1457 1402 1417 1402
query40 215 120 115 115
query41 64 60 60 60
query42 121 117 111 111
query43 488 506 455 455
query44 1326 815 814 814
query45 186 183 168 168
query46 823 1024 639 639
query47 1763 1776 1694 1694
query48 390 433 325 325
query49 822 524 469 469
query50 638 693 407 407
query51 4116 4071 4075 4071
query52 112 114 98 98
query53 220 250 186 186
query54 582 560 501 501
query55 123 81 83 81
query56 298 305 282 282
query57 1140 1136 1087 1087
query58 267 252 261 252
query59 2555 2670 2519 2519
query60 325 327 305 305
query61 130 126 126 126
query62 839 735 665 665
query63 225 182 176 176
query64 4318 1011 667 667
query65 4350 4228 4233 4228
query66 1138 419 313 313
query67 15716 15604 15432 15432
query68 8650 880 516 516
query69 462 308 261 261
query70 1179 1122 1084 1084
query71 473 307 297 297
query72 5317 4696 4832 4696
query73 706 589 342 342
query74 9117 9027 8675 8675
query75 4088 3213 2695 2695
query76 3717 1200 753 753
query77 775 383 283 283
query78 9902 10115 9304 9304
query79 3092 808 566 566
query80 650 517 434 434
query81 481 263 212 212
query82 477 127 97 97
query83 277 249 226 226
query84 294 104 86 86
query85 771 363 313 313
query86 339 296 282 282
query87 4473 4407 4335 4335
query88 2801 2237 2235 2235
query89 438 305 289 289
query90 1961 211 213 211
query91 143 142 111 111
query92 78 59 57 57
query93 2125 951 579 579
query94 660 423 309 309
query95 378 296 287 287
query96 475 564 273 273
query97 3178 3230 3101 3101
query98 230 217 199 199
query99 1409 1392 1265 1265
Total cold run time: 276385 ms
Total hot run time: 185529 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2853152412
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2853752250
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2853862172
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2841327703
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "feiniaofeiafei (via GitHub)" <gi...@apache.org>.
feiniaofeiafei commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2853739305
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2841433345
<details>
<summary>ClickBench: <b>Total hot run time: 29.03 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 88580ea453cb81838042e5bcc1bc3abfd91a7977, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.12
query3 0.25 0.20 0.19
query4 1.59 0.20 0.20
query5 0.61 0.57 0.58
query6 1.17 0.70 0.72
query7 0.02 0.02 0.02
query8 0.04 0.04 0.03
query9 0.58 0.52 0.52
query10 0.57 0.58 0.57
query11 0.16 0.10 0.11
query12 0.15 0.11 0.11
query13 0.61 0.59 0.59
query14 0.78 0.80 0.80
query15 0.87 0.84 0.86
query16 0.38 0.40 0.38
query17 1.00 1.02 1.05
query18 0.20 0.20 0.20
query19 1.85 1.85 1.79
query20 0.01 0.01 0.01
query21 15.43 0.90 0.55
query22 0.75 1.10 0.73
query23 14.97 1.42 0.64
query24 6.67 2.00 0.44
query25 0.49 0.26 0.14
query26 0.57 0.16 0.14
query27 0.05 0.05 0.05
query28 9.14 0.85 0.44
query29 12.54 3.93 3.27
query30 0.24 0.10 0.07
query31 2.82 0.59 0.37
query32 3.23 0.54 0.46
query33 3.02 3.09 3.07
query34 15.74 5.14 4.57
query35 4.59 4.53 4.55
query36 0.66 0.50 0.48
query37 0.08 0.07 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.02
query40 0.18 0.13 0.12
query41 0.08 0.03 0.02
query42 0.03 0.03 0.02
query43 0.03 0.03 0.04
Total cold run time: 102.39 s
Total hot run time: 29.03 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2853152390
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50573: [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n))
URL: https://github.com/apache/doris/pull/50573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2841385750
<details>
<summary>TPC-H: <b>Total hot run time: 34089 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 88580ea453cb81838042e5bcc1bc3abfd91a7977, data reload: false
------ Round 1 ----------------------------------
q1 26033 5101 5063 5063
q2 2069 274 179 179
q3 10441 1246 729 729
q4 10241 978 517 517
q5 7512 2440 2362 2362
q6 184 168 133 133
q7 927 746 628 628
q8 9304 1297 1105 1105
q9 6761 5095 5093 5093
q10 6801 2285 1897 1897
q11 484 292 279 279
q12 349 354 210 210
q13 17753 3687 3074 3074
q14 223 235 213 213
q15 549 491 483 483
q16 412 432 369 369
q17 612 865 383 383
q18 7526 7365 7143 7143
q19 1177 942 558 558
q20 355 339 233 233
q21 4137 2631 2458 2458
q22 1072 1039 980 980
Total cold run time: 114922 ms
Total hot run time: 34089 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5101 5085 5096 5085
q2 260 334 227 227
q3 2146 2671 2329 2329
q4 1341 1811 1359 1359
q5 4519 4446 4468 4446
q6 215 173 128 128
q7 1888 1865 1803 1803
q8 2561 2462 2487 2462
q9 7210 7113 7169 7113
q10 3004 3155 2719 2719
q11 561 526 479 479
q12 654 735 579 579
q13 3513 3906 3311 3311
q14 275 293 267 267
q15 523 493 483 483
q16 450 493 429 429
q17 1138 1535 1396 1396
q18 7789 7391 7480 7391
q19 806 885 1036 885
q20 1988 2034 1908 1908
q21 5229 4631 4593 4593
q22 1066 1029 984 984
Total cold run time: 52237 ms
Total hot run time: 50376 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-2841327408
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](nereids)fix fe const fold cannot process cast('abc' as char) and cast('abc' as char(n)) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50573:
URL: https://github.com/apache/doris/pull/50573#issuecomment-3483125262
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org