You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/09/08 07:52:01 UTC
[GitHub] [flink] 1996fanrui opened a new pull request, #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
1996fanrui opened a new pull request, #23379:
URL: https://github.com/apache/flink/pull/23379
## What is the purpose of the change
When the program plan could not be fetched, the root cause may be: the main method doesn't call the `env.execute()`. We can optimize the message to help user find this root cause.
## Brief change log
[FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23379:
URL: https://github.com/apache/flink/pull/23379#issuecomment-1711240408
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9b26d2ed9c52e94d3259e5014dcc9edf7b55e5c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b26d2ed9c52e94d3259e5014dcc9edf7b55e5c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9b26d2ed9c52e94d3259e5014dcc9edf7b55e5c8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RocMarshal commented on a diff in pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #23379:
URL: https://github.com/apache/flink/pull/23379#discussion_r1321600006
##########
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramUtils.java:
##########
@@ -183,7 +183,8 @@ public static Pipeline getPipelineFromProgram(
throw generateException(
program,
- "The program plan could not be fetched - the program aborted pre-maturely.",
+ "The program plan could not be fetched - the program aborted pre-maturely. "
+ + "The root cause may be that the main method doesn't call env.execute().",
Review Comment:
It looks like a reminder to the starter, Do we need to add env. executeAsync() as well ？
##########
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramUtils.java:
##########
@@ -183,7 +183,8 @@ public static Pipeline getPipelineFromProgram(
throw generateException(
program,
- "The program plan could not be fetched - the program aborted pre-maturely.",
+ "The program plan could not be fetched - the program aborted pre-maturely. "
+ + "The root cause may be that the main method doesn't call env.execute().",
Review Comment:
It looks like a reminder to the starter, Do we need to add env. executeAsync() as well ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on a diff in pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on code in PR #23379:
URL: https://github.com/apache/flink/pull/23379#discussion_r1322476890
##########
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgramUtils.java:
##########
@@ -183,7 +183,8 @@ public static Pipeline getPipelineFromProgram(
throw generateException(
program,
- "The program plan could not be fetched - the program aborted pre-maturely.",
+ "The program plan could not be fetched - the program aborted pre-maturely. "
+ + "The root cause may be that the main method doesn't call env.execute().",
Review Comment:
Thanks for your point out, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui commented on pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23379:
URL: https://github.com/apache/flink/pull/23379#issuecomment-1712408406
cc @RocMarshal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] 1996fanrui merged pull request #23379: [FLINK-33065][client] Add possible root cause to the exception message when the program plan could not be fetched
Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #23379:
URL: https://github.com/apache/flink/pull/23379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org