You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/05 03:49:04 UTC
Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent
volume tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 2:49 a.m.)
Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
Changes
-------
Addressed comment.
Summary (updated)
-----------------
Added `DEFAULT_ROLE` constant to persistent volume tests.
Repository: mesos
Description (updated)
-------
Added `DEFAULT_ROLE` constant to persistent volume tests.
Diffs
-----
src/tests/persistent_volume_tests.cpp 2fb57814b2805bc76981d1877603a1a033f29289
Diff: https://reviews.apache.org/r/41613/diff/
Testing
-------
`GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
Thanks,
Greg Mann
Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent
volume tests.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review112801
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41613]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 5, 2016, 2:49 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 2:49 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `DEFAULT_ROLE` constant to persistent volume tests.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 2fb57814b2805bc76981d1877603a1a033f29289
>
> Diff: https://reviews.apache.org/r/41613/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 41613: Added `DEFAULT_ROLE` constant to persistent
volume tests.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review112752
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 一月 5, 2016, 2:49 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> -----------------------------------------------------------
>
> (Updated 一月 5, 2016, 2:49 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `DEFAULT_ROLE` constant to persistent volume tests.
>
>
> Diffs
> -----
>
> src/tests/persistent_volume_tests.cpp 2fb57814b2805bc76981d1877603a1a033f29289
>
> Diff: https://reviews.apache.org/r/41613/diff/
>
>
> Testing
> -------
>
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
>
>
> Thanks,
>
> Greg Mann
>
>