You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "fjtirado (via GitHub)" <gi...@apache.org> on 2024/10/11 15:54:11 UTC
[PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
fjtirado opened a new pull request, #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720
Fix https://github.com/apache/incubator-kie-kogito-runtimes/issues/3719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720#discussion_r1803244907
##########
kogito-serverless-workflow/kogito-serverless-workflow-executor-tests/src/test/resources/logback.xml:
##########
@@ -0,0 +1,11 @@
+<configuration>
Review Comment:
yes, Im not sure is needed or not, without it, in my local testing all debug traces were printed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "gmunozfe (via GitHub)" <gi...@apache.org>.
gmunozfe commented on code in PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720#discussion_r1802918019
##########
kogito-serverless-workflow/kogito-serverless-workflow-executor-tests/src/test/resources/logback.xml:
##########
@@ -0,0 +1,11 @@
+<configuration>
Review Comment:
I guess this is just for setting up during your testing
##########
api/kogito-events-core/src/main/java/org/kie/kogito/event/impl/adapter/AdapterHelper.java:
##########
@@ -69,6 +69,7 @@ public static String buildSource(String service, String processId) {
if (processId == null) {
return null;
} else {
+ processId = processId.replace(" ", "-");
Review Comment:
perhaps a logger info/debug statement after this replacement is useful, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720#issuecomment-2407935792
**PR job** `#1` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/display/redirect
**Test results:**
- PASSED: 3367
- FAILED: 3
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/testReport/org.kie.kogito.quarkus.workflows/CallbackStateIT/callbackStateWithError/">org.kie.kogito.quarkus.workflows.CallbackStateIT.callbackStateWithError</a></summary>
<br/>Expecting map:<br/> {"query"="GENERATE_ERROR_QUERY"}<br/>to contain entries:<br/> ["lastExecutedState"="FinalizeWithError"]<br/>but could not find the following map entries:<br/> ["lastExecutedState"="FinalizeWithError"]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/testReport/org.kie.kogito.quarkus.workflows/CallbackStateTimeoutsIT/callbackStateWithError/">org.kie.kogito.quarkus.workflows.CallbackStateTimeoutsIT.callbackStateWithError</a></summary>
<br/>Expecting map:<br/> {"query"="GENERATE_ERROR_QUERY"}<br/>to contain entries:<br/> ["lastExecutedState"="FinalizeWithError"]<br/>but could not find the following map entries:<br/> ["lastExecutedState"="FinalizeWithError"]
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/1/testReport/org.kie.kogito.quarkus.workflows/CallbackStateWithTimeoutsErrorHandlerIT/callbackStateWithError/">org.kie.kogito.quarkus.workflows.CallbackStateWithTimeoutsErrorHandlerIT.callbackStateWithError</a></summary>
<br/>Expecting map:<br/> {"query"="GENERATE_ERROR_QUERY"}<br/>to contain entries:<br/> ["lastExecutedState"="FinalizeWithError"]<br/>but could not find the following map entries:<br/> ["lastExecutedState"="FinalizeWithError"]
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "kie-ci3 (via GitHub)" <gi...@apache.org>.
kie-ci3 commented on PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720#issuecomment-2411387612
**PR job** `#2` was: **UNSTABLE**
Possible explanation: This should be test failures
<details>
<summary><b>Reproducer</b></summary>
build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution
</details>
Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/display/redirect
**Test results:**
- PASSED: 3368
- FAILED: 3
Those are the test failures:
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/testReport/org.jbpm.bpmn2/IntermediateEventTest/testTimerBoundaryEventInterrupting/">org.jbpm.bpmn2.IntermediateEventTest.testTimerBoundaryEventInterrupting</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/testReport/org.jbpm.bpmn2/IntermediateEventTest/testIntermediateCatchEventTimerDuration/">org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerDuration</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
<details>
<summary><a href="https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3720/2/testReport/org.jbpm.bpmn2/IntermediateEventTest/testEventBasedSplit2/">org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit2</a></summary>
<br/>expected: 2<br/> but was: 1
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720#discussion_r1803240826
##########
api/kogito-events-core/src/main/java/org/kie/kogito/event/impl/adapter/AdapterHelper.java:
##########
@@ -69,6 +69,7 @@ public static String buildSource(String service, String processId) {
if (processId == null) {
return null;
} else {
+ processId = processId.replace(" ", "-");
Review Comment:
source is not really used, we are filling up because is mandatory in the cloud event sepc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [Fix #3719] Unmarshall return ObjectNode that is event sensitive [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado merged PR #3720:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org