You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/29 20:28:43 UTC

[GitHub] [kafka] abbccdda commented on a change in pull request #8953: MINOR: re-enable EosBetaUpgradeIntegrationTest

abbccdda commented on a change in pull request #8953:
URL: https://github.com/apache/kafka/pull/8953#discussion_r447234048



##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##########
@@ -594,7 +594,7 @@ public static void waitForStandbyCompletion(final KafkaStreams streams,
                 final List<KeyValue<K, V>> readData =
                     readKeyValues(topic, consumer, waitTime, expectedNumRecords);
                 accumData.addAll(readData);
-                assertThat(reason, accumData.size(), is(greaterThanOrEqualTo(expectedNumRecords)));
+                assertThat(reason + ",  currently accumulated data is " + accumData, accumData.size(), is(greaterThanOrEqualTo(expectedNumRecords)));

Review comment:
       nit: should we also log expected records then?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org