[jira] Commented: (MPJNLP-11) Always wants to sign if maven.jnlp.signjar.store is emtpy

[ji...@codehaus.org]

The following comment has been added to this issue:

     Author: Emmanuel Venisse
    Created: Thu, 10 Jun 2004 12:51 AM
       Body:
Do you have a patch?
---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPJNLP-11?page=comments#action_20509

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPJNLP-11

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJNLP-11
    Summary: Always wants to sign if  maven.jnlp.signjar.store is emtpy
       Type: Bug

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-jnlp-plugin
   Versions:
             1.3

   Assignee: Emmanuel Venisse
   Reporter: Erik Husby

    Created: Wed, 9 Jun 2004 4:07 PM
    Updated: Thu, 10 Jun 2004 12:51 AM
Environment: Windows XP, maven rc3

Description:
The JNLP plugin always wants to sign the jars even though a keystore does not exist. The ant code that checks for the existence of the keystore succeeds even if the property maven.jnlp.signjar.store is empty. This can easily be demonstrated by adding this to a maven.xml file and executing it.

<goal name="junk">
        <ant:available file="${maven.jnlp.signjar.store}" property="maven.jnlp.store.exists"/>
  <ant:echo message="maven.jnlp.signjar.store=${maven.jnlp.signjar.store}"/>
  <ant:echo message="exists=${maven.jnlp.store.exists}"/>

</goal>

>maven junk
 __  __
|  \/  |__ _Apache__ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|  v. 1.0-rc3

build:start:

junk:
    [echo] maven.jnlp.signjar.store=
    [echo] exists=true
BUILD SUCCESSFUL
Total time: 2 seconds
Finished at: Wed Jun 09 16:00:15 EDT 2004

It would be better if the plugin defined a default value for the property or better yet, a property such as "maven.jnlp.signjar" which would be true if the jars are to be signed and false otherwise.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org