You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "eunhwa99 (via GitHub)" <gi...@apache.org> on 2025/08/21 14:54:46 UTC
[PR] [ZEPPELIN-6289] Add Unit tests for StaticRepl.class [zeppelin]
eunhwa99 opened a new pull request, #5038:
URL: https://github.com/apache/zeppelin/pull/5038
### What is this PR for?
This PR adds JUnit tests for the StaticRepl.execute method to verify correct behavior for compilation and execution of dynamically generated Java code.
It covers scenarios such as:
- Successful execution of simple print statements
- Classes without a main method
- Code with syntax errors
- Compilation failures
- Runtime exceptions during execution
These tests improve test coverage and help prevent regressions in the StaticRepl class.
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
* [ZEPPELIN-6289](https://issues.apache.org/jira/browse/ZEPPELIN-6289)
### How should this be tested?
* Run all new unit tests in StaticReplTest
* All tests should pass, verifying correct handling of compilation and runtime scenarios.
### Screenshots (if appropriate)
- test coverage (Class, Method, Line)
<img width="1554" height="118" alt="image" src="https://github.com/user-attachments/assets/121b4574-c418-4be7-a6e2-7a33fa9c8cf3" />
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6289] Add Unit tests for StaticRepl.class [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #5038:
URL: https://github.com/apache/zeppelin/pull/5038#issuecomment-3213541361
The current test coverage is already very good (90+%). I therefore reject this MR.
<img width="1382" height="446" alt="image" src="https://github.com/user-attachments/assets/79799044-42b1-4e12-9e5e-974f4d354e38" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6289] Add Unit tests for StaticRepl.class [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer closed pull request #5038: [ZEPPELIN-6289] Add Unit tests for StaticRepl.class
URL: https://github.com/apache/zeppelin/pull/5038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org