You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/10 05:53:09 UTC

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

maobaolong opened a new pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187


   ## What changes were proposed in this pull request?
   
   Reanme `dfs.container.ratis.num.write.chunk.thread` to `dfs.container.ratis.num.write.chunk.thread.per.disk
`
   
   to clearly express the meaning of this key, if it configured to 10, then the thread num would be 10 * numOfDisk. 
   
   
   ## What is the link to the Apache JIRA
   
   HDDS-3951
   
   ## How was this patch tested?
   
   NO Need, just rename config key.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657919706


   @ChenSammi @xiaoyuyao Thank you for your review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657389570


   @maobaolong,  suggest change from " per disk" to " per volume" to be consistent with other datanode property naming style. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

Posted by GitBox <gi...@apache.org>.
maobaolong commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657397401


   @ChenSammi Thanks for your suggestion，I have addressed your comment，PTAL


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187#issuecomment-657701542


   LGTM, +1. Thanks @maobaolong  for the contribution and all for the reviews. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1187: HDDS-3951. Rename the num.write.chunk.thread key.

Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #1187:
URL: https://github.com/apache/hadoop-ozone/pull/1187


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org