You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "David Waters (JIRA)" <de...@myfaces.apache.org> on 2008/02/28 13:41:51 UTC

[jira] Created: (TRINIDAD-976) ID's incorrect with in tr:iterator component UIXIterator StampState

ID's incorrect with in tr:iterator component UIXIterator StampState
-------------------------------------------------------------------

                 Key: TRINIDAD-976
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-976
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.2.6-core, 1.2.3-core, 1.2.7-core
            Reporter: David Waters


Id's for most components within a tr:iterator are the same for each iteration.
If a component has not state as defined by StampState._createState its id does not get set, clearing the cached version of clientId as done in StampState.restoreStampState for components with state.
e.g.
<tr:itrirator id="itr" ...>
<h:commandButton id="button" />
<h:inputText id="input"/>
</tr:iterator>

produces something like
<input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:0:input" ..>
<input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:1:input" ..>
<input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:2:input" ..>


I suggest the correct behavior would be 
<input type="submit" id="form:itr:0:button" .../><input type="text" id="form:itr:0:input" ..>
<input type="submit" id="form:itr:1:button" .../><input type="text" id="form:itr:1:input" ..>
<input type="submit" id="form:itr:2:button" .../><input type="text" id="form:itr:2:input" ..>



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TRINIDAD-976) ID's incorrect with in tr:iterator component UIXIterator StampState

Posted by "David Waters (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TRINIDAD-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573258#action_12573258 ] 

David Waters commented on TRINIDAD-976:
---------------------------------------

the effected version are the versions I have tested upon, I assume that this is also a problem for at least the version inbetween 1.2.4 1.2.5, also it may well be worth checking the 1.0.* trunk to see if this patch is helpful. currently I am not in a position to test against other then JSF 1.2.

Thanks so much for looking into this patch please provide any feed back that could make your life easier next time.

David Waters.

> ID's incorrect with in tr:iterator component UIXIterator StampState
> -------------------------------------------------------------------
>
>                 Key: TRINIDAD-976
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-976
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.3-core, 1.2.6-core, 1.2.7-core
>            Reporter: David Waters
>         Attachments: trinidad-apiTRINIDAD-976.patch
>
>
> Id's for most components within a tr:iterator are the same for each iteration.
> If a component has not state as defined by StampState._createState its id does not get set, clearing the cached version of clientId as done in StampState.restoreStampState for components with state.
> e.g.
> <tr:itrirator id="itr" ...>
> <h:commandButton id="button" />
> <h:inputText id="input"/>
> </tr:iterator>
> produces something like
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:0:input" ..>
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:1:input" ..>
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:2:input" ..>
> I suggest the correct behavior would be 
> <input type="submit" id="form:itr:0:button" .../><input type="text" id="form:itr:0:input" ..>
> <input type="submit" id="form:itr:1:button" .../><input type="text" id="form:itr:1:input" ..>
> <input type="submit" id="form:itr:2:button" .../><input type="text" id="form:itr:2:input" ..>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (TRINIDAD-976) ID's incorrect with in tr:iterator component UIXIterator StampState

Posted by "David Waters (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Waters updated TRINIDAD-976:
----------------------------------

    Status: Patch Available  (was: Open)

> ID's incorrect with in tr:iterator component UIXIterator StampState
> -------------------------------------------------------------------
>
>                 Key: TRINIDAD-976
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-976
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.3-core, 1.2.6-core, 1.2.7-core
>            Reporter: David Waters
>         Attachments: trinidad-apiTRINIDAD-976.patch
>
>
> Id's for most components within a tr:iterator are the same for each iteration.
> If a component has not state as defined by StampState._createState its id does not get set, clearing the cached version of clientId as done in StampState.restoreStampState for components with state.
> e.g.
> <tr:itrirator id="itr" ...>
> <h:commandButton id="button" />
> <h:inputText id="input"/>
> </tr:iterator>
> produces something like
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:0:input" ..>
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:1:input" ..>
> <input type="submit" id="form:itr:button" .../><input type="text" id="form:itr:2:input" ..>
> I suggest the correct behavior would be 
> <input type="submit" id="form:itr:0:button" .../><input type="text" id="form:itr:0:input" ..>
> <input type="submit" id="form:itr:1:button" .../><input type="text" id="form:itr:1:input" ..>
> <input type="submit" id="form:itr:2:button" .../><input type="text" id="form:itr:2:input" ..>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.