You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2022/07/06 10:18:07 UTC
[doris] branch master updated: [BugFix](Array) fix DataTypeArray to_string use after free (#10640)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 29d4809c80 [BugFix](Array) fix DataTypeArray to_string use after free (#10640)
29d4809c80 is described below
commit 29d4809c80550ab7c864b415da1d95fb28b4793a
Author: lihangyu <15...@163.com>
AuthorDate: Wed Jul 6 18:18:00 2022 +0800
[BugFix](Array) fix DataTypeArray to_string use after free (#10640)
ColumnArray::convert_to_full_column_if_const override the base function
and ColumnArray::create generate a temporary variable
---
be/src/vec/data_types/data_type_array.cpp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/be/src/vec/data_types/data_type_array.cpp b/be/src/vec/data_types/data_type_array.cpp
index 40aa07011b..4c459ed4b8 100644
--- a/be/src/vec/data_types/data_type_array.cpp
+++ b/be/src/vec/data_types/data_type_array.cpp
@@ -96,8 +96,8 @@ void DataTypeArray::to_pb_column_meta(PColumnMeta* col_meta) const {
}
void DataTypeArray::to_string(const IColumn& column, size_t row_num, BufferWritable& ostr) const {
- auto& data_column =
- assert_cast<const ColumnArray&>(*column.convert_to_full_column_if_const().get());
+ auto ptr = column.convert_to_full_column_if_const();
+ auto& data_column = assert_cast<const ColumnArray&>(*ptr.get());
auto& offsets = data_column.get_offsets();
size_t offset = offsets[row_num - 1];
@@ -115,8 +115,8 @@ void DataTypeArray::to_string(const IColumn& column, size_t row_num, BufferWrita
}
std::string DataTypeArray::to_string(const IColumn& column, size_t row_num) const {
- auto& data_column =
- assert_cast<const ColumnArray&>(*column.convert_to_full_column_if_const().get());
+ auto ptr = column.convert_to_full_column_if_const();
+ auto& data_column = assert_cast<const ColumnArray&>(*ptr.get());
auto& offsets = data_column.get_offsets();
size_t offset = offsets[row_num - 1];
@@ -183,4 +183,4 @@ Status DataTypeArray::from_string(ReadBuffer& rb, IColumn* column) const {
return Status::OK();
}
-} // namespace doris::vectorized
\ No newline at end of file
+} // namespace doris::vectorized
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org