You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "coderzc (via GitHub)" <gi...@apache.org> on 2023/03/03 11:55:58 UTC

[GitHub] [pulsar] coderzc opened a new pull request, #19706: [improve][broker][PIP-195] Cut off snapshot segment according to maxIndexesPerBucketSnapshotSegment

coderzc opened a new pull request, #19706:
URL: https://github.com/apache/pulsar/pull/19706

   PIP: #16763 
   
   ### Motivation
   
   currently, the tracker only cut off snapshot segments according to the time range, to prevent single snapshot segment oversize we should add the max number limitation for snapshot segment.
   
   ### Modifications
   
   * Cut off snapshot segment according to config `delayedDeliveryMaxIndexesPerBucketSnapshotSegment`.
   * Remove unimplemented configuration `delayedDeliverySharedIndexEnabled`
   * Improve variable types
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #19706: [improve][broker][PIP-195] Cut off snapshot segment according to maxIndexesPerBucketSnapshotSegment

Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on PR #19706:
URL: https://github.com/apache/pulsar/pull/19706#issuecomment-1467569796

   Please don't forget to add configuration to `broker.conf `and `standalone.conf`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc merged pull request #19706: [improve][broker][PIP-195] Cut off snapshot segment according to maxIndexesPerBucketSnapshotSegment

Posted by "coderzc (via GitHub)" <gi...@apache.org>.
coderzc merged PR #19706:
URL: https://github.com/apache/pulsar/pull/19706


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #19706: [improve][broker][PIP-195] Cut off snapshot segment according to maxIndexesPerBucketSnapshotSegment

Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on PR #19706:
URL: https://github.com/apache/pulsar/pull/19706#issuecomment-1467450070

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org