You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@impala.apache.org by "Jinchul Kim (JIRA)" <ji...@apache.org> on 2017/12/06 06:30:00 UTC

[jira] [Created] (IMPALA-6282) Not easy to find where the error happens in be unit test

Jinchul Kim created IMPALA-6282:
-----------------------------------

             Summary: Not easy to find where the error happens in be unit test
                 Key: IMPALA-6282
                 URL: https://issues.apache.org/jira/browse/IMPALA-6282
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
            Reporter: Jinchul Kim


In expr-test, the line numbers where the failures happen are not helpful when we use TestValue/Test* which are helper functions in be/src/exprs/expr-test.cc.
The line numbers mean assertion line in helper functions, but we expect line numbers of actual test failures(i.e. caller's line number). I think we can get caller's line number by using boost stacktrace: https://github.com/boostorg/stacktrace

{noformat}
[ RUN      ] ExprTest.TimestampFunctions
be/src/exprs/expr-test.cc:257: Failure
Value of: result_types[0].type
  Actual: "null"
Expected: TypeToOdbcString(expr_type.type)
Which is: "int"
NULL
be/src/exprs/expr-test.cc:257: Failure
Value of: result_types[0].type
  Actual: "null"
Expected: TypeToOdbcString(expr_type.type)
Which is: "string"
NULL
be/src/exprs/expr-test.cc:257: Failure
Value of: result_types[0].type
  Actual: "tinyint"
Expected: TypeToOdbcString(expr_type.type)
Which is: "int"
0
be/src/exprs/expr-test.cc:257: Failure
Value of: result_types[0].type
  Actual: "null"
Expected: TypeToOdbcString(expr_type.type)
Which is: "int"
NULL
be/src/exprs/expr-test.cc:257: Failure
Value of: result_types[0].type
  Actual: "null"
Expected: TypeToOdbcString(expr_type.type)
Which is: "string"
NULL{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)