You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Blake Eggleston (JIRA)" <ji...@apache.org> on 2015/10/14 17:42:06 UTC

[jira] [Updated] (CASSANDRA-10518) initialDirectories passed into ColumnFamilyStore contructor

     [ https://issues.apache.org/jira/browse/CASSANDRA-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Blake Eggleston updated CASSANDRA-10518:
----------------------------------------
    Attachment: 10518-v2.txt

bq. afaict initialDirectories is only used to figure out the max generation in createColumnFamilyStore(...)

Right, sorry about that. It also needs to be used in the sstable listing that happens in the ColumnFamilyStore constructor. The updated patch moves the post-instantiation directories definition into AbstractCompactionStrategy.

bq. initialDirectories is static and we only add more directories to it - if you have several tables with custom data directories, wont they all just be appended?

Yes, this is only used for discovering sstables on cfs instantiation. Initial sstable listing happens before the compaction strategy is loaded, and it's possible for tables to have sstables in directories other than those covered by the current compaction strategy if the compaction strategy for a table has changed.

> initialDirectories passed into ColumnFamilyStore contructor
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-10518
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10518
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.0.0 rc2
>
>         Attachments: 10518-v2.txt, initialDirectoriesFixV1.patch
>
>
> One of the goals of CASSANDRA-8671 was to let compaction strategies write to directories not used by normal tables, and the field {{ColumnFamilyStore.initialDirectories}} was added to make sstables in those directories discoverable on cfs instantiation.
> Unfortunately, in my patch, I passed the full list of directories {{initialDirectories}} into the ColumnFamilyStore constructor, effectively making these directories usable by any table. The attached patch fixes this, and elaborates on the correct usage of the usage of {{ColumnFamilyStore.addInitialDirectories}} in it's comment



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)