You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "junichi11 (via GitHub)" <gi...@apache.org> on 2023/11/09 03:05:25 UTC
[PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
junichi11 opened a new pull request, #6675:
URL: https://github.com/apache/netbeans/pull/6675
- #4725
- https://wiki.php.net/rfc/dnf_types
### PHP 8.2 Support: Disjunctive Normal Form Types (Part 9)
- Fix the code completion, the code generator, and the `ImplementAbstractMethodsHintError` for overriding/implementing methods
- Add unit tests
### PHP 8.2 Support: Disjunctive Normal Form Types (Part 10)
- Fix the mark occurrences and the go to declaration features
- Add unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 merged PR #6675:
URL: https://github.com/apache/netbeans/pull/6675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#issuecomment-1805890633
> CI failed but it is not related to this PR.
@junichi11 you might want to rebase that PHP NB21 branch on latest master to bring in CI fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387931149
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
I see. maybe types are 12 or less in most cases.
So, I'll use the constructor without parameters. (16*0.75 = 12)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#issuecomment-1803766249
Fixed: https://github.com/apache/netbeans/compare/ebb02defca1065c1047d8789e57c228cddadd079..9523012c561b841df1a5be8374807470d3413d9b
@tmysik Thank you for your review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#issuecomment-1803492337
CI failed but it is not related to this PR.
Actual changes are 4 files. Other than those are unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387933372
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
Or simply use `size * 1.5` and you should be safe, always :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#issuecomment-1805903455
> you might want to rebase that PHP NB21 branch on latest master to bring in CI fixes.
@neilcsmith-net Yes, I might do that later. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387882407
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
Nitpick: please note that for `Set` (and `Map`), this ctor is a bit different in comparison to the `List` one (sets or maps have load factor, by default 0.75, so actually, the initial size should be bigger).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387939251
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
I'll change the size to it :) Thank you, Tomas!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "tmysik (via GitHub)" <gi...@apache.org>.
tmysik commented on code in PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#discussion_r1387941771
##########
php/php.editor/src/org/netbeans/modules/php/editor/csl/DeclarationFinderImpl.java:
##########
@@ -397,6 +402,29 @@ private OffsetRange getVarCommentOffsetRange(TokenSequence<PHPTokenId> ts, Strin
return null;
}
+ private Set<OffsetRange> getTypeRanges(String types, int startOffset) {
+ String[] splitTypes = Type.splitTypes(types);
+ Set<OffsetRange> ranges = new HashSet<>(splitTypes.length);
Review Comment:
My pleasure, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] PHP 8.2 Support: Disjunctive Normal Form Types #4725 [netbeans]
Posted by "junichi11 (via GitHub)" <gi...@apache.org>.
junichi11 commented on PR #6675:
URL: https://github.com/apache/netbeans/pull/6675#issuecomment-1806067947
I'll rebase `php-nb21-features` branch after I merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists