You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2018/01/08 00:29:50 UTC

[GitHub] spark pull request #20182: [SPARK-22985] Fix argument escaping bug in from_u...

GitHub user JoshRosen opened a pull request:

    https://github.com/apache/spark/pull/20182

    [SPARK-22985] Fix argument escaping bug in from_utc_timestamp / to_utc_timestamp codegen

    ## What changes were proposed in this pull request?
    
    This patch adds additional escaping in `from_utc_timestamp` / `to_utc_timestamp` expression codegen in order to a bug where invalid timezones which contain special characters could cause generated code to fail to compile. 
    
    ## How was this patch tested?
    
    New regression tests in `DateExpressionsSuite`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JoshRosen/spark SPARK-22985-fix-utc-timezone-function-escaping-bugs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20182
    
----
commit 2d10131892e54182517185102a362dd17de2af9b
Author: Josh Rosen <jo...@...>
Date:   2018-01-08T00:25:30Z

    regression test

commit d94feed8e1f10c1610cae7cb3f7a3ad7014123e9
Author: Josh Rosen <jo...@...>
Date:   2018-01-08T00:26:05Z

    Fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20182: [SPARK-22985] Fix argument escaping bug in from_utc_time...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20182
  
    **[Test build #85776 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85776/testReport)** for PR 20182 at commit [`d94feed`](https://github.com/apache/spark/commit/d94feed8e1f10c1610cae7cb3f7a3ad7014123e9).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20182: [SPARK-22985] Fix argument escaping bug in from_utc_time...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20182
  
    **[Test build #85776 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85776/testReport)** for PR 20182 at commit [`d94feed`](https://github.com/apache/spark/commit/d94feed8e1f10c1610cae7cb3f7a3ad7014123e9).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20182: [SPARK-22985] Fix argument escaping bug in from_utc_time...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20182
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20182: [SPARK-22985] Fix argument escaping bug in from_utc_time...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20182
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85776/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20182: [SPARK-22985] Fix argument escaping bug in from_utc_time...

Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/20182
  
    Thanks! Merged to master/2.3


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20182: [SPARK-22985] Fix argument escaping bug in from_u...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20182


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org