[jira] [Commented] (HADOOP-19931) Summary: SSLHostnameVerifier subject CN parsing is too brittle

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-19931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18093515#comment-18093515 ] 

ASF GitHub Bot commented on HADOOP-19931:
-----------------------------------------

steveloughran opened a new pull request, #8584:
URL: https://github.com/apache/hadoop/pull/8584

   
   ### Description of PR
   
   Move to a real parser of x509 strings.
   
   
   ### How was this patch tested?
   
   new tests.
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html




>  Summary: SSLHostnameVerifier subject CN parsing is too brittle
> ---------------------------------------------------------------
>
>                 Key: HADOOP-19931
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19931
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: net
>    Affects Versions: 3.5.0, 3.4.3
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>
> Certificates.getCNs() extracts CNs by string-tokenising getSubjectX500Principal().toString() on commas and matching CN=. 
> This is too brittle.
> Parse the subject with LdapName and take CNs from actual CN RDNs instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org