[GitHub] [pulsar] eolivelli commented on a change in pull request #8590: Update ZooKeeper to 3.6.2 and Curator to 5.1.0

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #8590:
URL: https://github.com/apache/pulsar/pull/8590#discussion_r557293992



##########
File path: managed-ledger/pom.xml
##########
@@ -84,7 +84,16 @@
       <classifier>tests</classifier>
       <scope>test</scope>
     </dependency>
-
+    <dependency>
+       <groupId>io.dropwizard.metrics</groupId>

Review comment:
       because from zk 3.6 onwards the "zookeeper" Maven artifact does not import those dependencies anymore to the dependant projects.
   This is because we (ZooKeeper project community) want to say that this artifact is only the "zookeeper java client" and the zookeeper java client does not need such jars.
   But we still do not provide a "zookeeper server" jar
   
   In Pulsar we are also running the ZooKeeper server (both for production and for tests) and so we need to explicitly add those two jar to the build, otherwise the ZooKeeper server won't start




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org