You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/12/20 15:21:34 UTC
[pulsar] 05/11: Remove wrong visible testing annotation in function workers (#12621)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch branch-2.9
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 5e7f9cd60f57ca4591944de3a089bf6cc746ac8c
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Fri Nov 5 15:39:37 2021 +0800
Remove wrong visible testing annotation in function workers (#12621)
* Remove wrong visible testing annotation
* Remove unused method since 2017
(cherry picked from commit 8496afc58bdd27c47cde8a9ba3c76b80ab796320)
---
.../functions/worker/FunctionMetaDataManager.java | 19 +++++++------------
.../functions/worker/FunctionRuntimeManager.java | 9 ---------
.../pulsar/functions/worker/PulsarWorkerService.java | 4 ----
.../pulsar/functions/worker/SchedulerManager.java | 2 --
.../apache/pulsar/functions/worker/WorkerService.java | 1 -
.../pulsar/functions/worker/dlog/DLInputStream.java | 11 -----------
.../pulsar/functions/worker/rest/WorkerServer.java | 13 -------------
.../functions/worker/rest/api/ComponentImpl.java | 5 +----
.../functions/worker/rest/api/FunctionsImpl.java | 2 --
.../pulsar/functions/worker/rest/api/SinksImpl.java | 2 --
.../pulsar/functions/worker/rest/api/SourcesImpl.java | 2 --
.../pulsar/functions/worker/rest/api/WorkerImpl.java | 6 +-----
.../worker/service/WorkerServiceWithClassLoader.java | 2 --
.../functions/worker/FunctionMetaDataManagerTest.java | 12 ++++++------
14 files changed, 15 insertions(+), 75 deletions(-)
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
index 1ff1b2b..5388bd7 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
@@ -18,7 +18,6 @@
*/
package org.apache.pulsar.functions.worker;
-import com.google.common.annotations.VisibleForTesting;
import java.io.IOException;
import java.util.Collection;
import java.util.LinkedList;
@@ -62,7 +61,6 @@ import org.apache.pulsar.functions.utils.FunctionCommon;
public class FunctionMetaDataManager implements AutoCloseable {
// Represents the global state
// tenant -> namespace -> (function name, FunctionRuntimeInfo)
- @VisibleForTesting
final Map<String, Map<String, Map<String, FunctionMetaData>>> functionMetaDataMap = new ConcurrentHashMap<>();
private final SchedulerManager schedulerManager;
@@ -240,7 +238,7 @@ public class FunctionMetaDataManager implements AutoCloseable {
}
lastMessageSeen = builder.send();
if (delete) {
- needsScheduling = proccessDeregister(functionMetaData);
+ needsScheduling = processDeregister(functionMetaData);
} else {
needsScheduling = processUpdate(functionMetaData);
}
@@ -359,7 +357,7 @@ public class FunctionMetaDataManager implements AutoCloseable {
this.processUpdate(serviceRequest.getFunctionMetaData());
break;
case DELETE:
- this.proccessDeregister(serviceRequest.getFunctionMetaData());
+ this.processDeregister(serviceRequest.getFunctionMetaData());
break;
default:
log.warn("Received request with unrecognized type: {}", serviceRequest);
@@ -373,7 +371,7 @@ public class FunctionMetaDataManager implements AutoCloseable {
String functionName = FunctionCommon.extractNameFromFullyQualifiedName(message.getKey());
if (message.getData() == null || message.getData().length == 0) {
// this is a delete message
- this.proccessDeregister(tenant, namespace, functionName, version);
+ this.processDeregister(tenant, namespace, functionName, version);
} else {
FunctionMetaData functionMetaData = FunctionMetaData.parseFrom(message.getData());
this.processUpdate(functionMetaData);
@@ -404,16 +402,15 @@ public class FunctionMetaDataManager implements AutoCloseable {
return false;
}
- @VisibleForTesting
- synchronized boolean proccessDeregister(FunctionMetaData deregisterRequestFs) throws IllegalArgumentException {
+ synchronized boolean processDeregister(FunctionMetaData deregisterRequestFs) throws IllegalArgumentException {
String functionName = deregisterRequestFs.getFunctionDetails().getName();
String tenant = deregisterRequestFs.getFunctionDetails().getTenant();
String namespace = deregisterRequestFs.getFunctionDetails().getNamespace();
- return proccessDeregister(tenant, namespace, functionName, deregisterRequestFs.getVersion());
+ return processDeregister(tenant, namespace, functionName, deregisterRequestFs.getVersion());
}
- synchronized boolean proccessDeregister(String tenant, String namespace,
- String functionName, long version) throws IllegalArgumentException {
+ synchronized boolean processDeregister(String tenant, String namespace,
+ String functionName, long version) throws IllegalArgumentException {
boolean needsScheduling = false;
@@ -437,7 +434,6 @@ public class FunctionMetaDataManager implements AutoCloseable {
return needsScheduling;
}
- @VisibleForTesting
synchronized boolean processUpdate(FunctionMetaData updateRequestFs) throws IllegalArgumentException {
log.debug("Process update request: {}", updateRequestFs);
@@ -481,7 +477,6 @@ public class FunctionMetaDataManager implements AutoCloseable {
return currentFunctionMetaData.getVersion() >= version;
}
- @VisibleForTesting
void setFunctionMetaData(FunctionMetaData functionMetaData) {
Function.FunctionDetails functionDetails = functionMetaData.getFunctionDetails();
if (!this.functionMetaDataMap.containsKey(functionDetails.getTenant())) {
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
index eaad132..d37049f 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
@@ -79,12 +79,10 @@ public class FunctionRuntimeManager implements AutoCloseable{
// all assignments
// WorkerId -> Function Fully Qualified InstanceId -> List<Assignments>
- @VisibleForTesting
Map<String, Map<String, Assignment>> workerIdToAssignments = new ConcurrentHashMap<>();
// All the runtime info related to functions executed by this worker
// Fully Qualified InstanceId - > FunctionRuntimeInfo
- @VisibleForTesting
class FunctionRuntimeInfos {
private Map<String, FunctionRuntimeInfo> functionRuntimeInfoMap = new ConcurrentHashMap<>();
@@ -114,10 +112,8 @@ public class FunctionRuntimeManager implements AutoCloseable{
}
}
- @VisibleForTesting
final FunctionRuntimeInfos functionRuntimeInfos = new FunctionRuntimeInfos();
- @VisibleForTesting
@Getter
final WorkerConfig workerConfig;
@@ -267,10 +263,6 @@ public class FunctionRuntimeManager implements AutoCloseable{
}
/**
- * Starts the function runtime manager
- */
-
- /**
* Get current assignments
* @return a map of current assignments in the following format
* {workerId : {FullyQualifiedInstanceId : Assignment}}
@@ -827,7 +819,6 @@ public class FunctionRuntimeManager implements AutoCloseable{
}
}
- @VisibleForTesting
void deleteAssignment(Assignment assignment) {
String fullyQualifiedInstanceId = FunctionCommon.getFullyQualifiedInstanceId(assignment.getInstance());
Map<String, Assignment> assignmentMap = this.workerIdToAssignments.get(assignment.getWorkerId());
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java
index 9c47dfe..3056a0d 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java
@@ -45,7 +45,6 @@ import org.apache.distributedlog.api.namespace.NamespaceBuilder;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.authentication.AuthenticationService;
import org.apache.pulsar.broker.authorization.AuthorizationService;
-import org.apache.pulsar.broker.cache.ConfigurationCacheService;
import org.apache.pulsar.broker.resources.PulsarResources;
import org.apache.pulsar.client.admin.PulsarAdmin;
import org.apache.pulsar.client.admin.PulsarAdminException;
@@ -55,12 +54,10 @@ import org.apache.pulsar.client.api.PulsarClientException;
import org.apache.pulsar.common.conf.InternalConfigurationData;
import org.apache.pulsar.common.naming.NamedEntity;
import org.apache.pulsar.common.naming.NamespaceName;
-import org.apache.pulsar.common.policies.data.ClusterData;
import org.apache.pulsar.common.policies.data.ClusterDataImpl;
import org.apache.pulsar.common.policies.data.Policies;
import org.apache.pulsar.common.policies.data.RetentionPolicies;
import org.apache.pulsar.common.policies.data.TenantInfoImpl;
-import org.apache.pulsar.common.policies.path.PolicyPath;
import org.apache.pulsar.common.util.SimpleTextOutputStream;
import org.apache.pulsar.functions.worker.rest.api.FunctionsImpl;
import org.apache.pulsar.functions.worker.rest.api.FunctionsImplV2;
@@ -188,7 +185,6 @@ public class PulsarWorkerService implements WorkerService {
);
}
- @VisibleForTesting
public void init(WorkerConfig workerConfig,
URI dlogUri,
boolean runAsStandalone) {
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
index 130e839..2fed499 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
@@ -371,7 +371,6 @@ public class SchedulerManager implements AutoCloseable {
return currentMembership;
}
- @VisibleForTesting
void invokeScheduler() {
long startTime = System.nanoTime();
@@ -561,7 +560,6 @@ public class SchedulerManager implements AutoCloseable {
assignmentsMovedInLastDrain = null;
}
- @VisibleForTesting
List<Assignment> invokeDrain(String workerId) {
long startTime = System.nanoTime();
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java
index f76f753..f5293ce 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java
@@ -21,7 +21,6 @@ package org.apache.pulsar.functions.worker;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.authentication.AuthenticationService;
import org.apache.pulsar.broker.authorization.AuthorizationService;
-import org.apache.pulsar.broker.cache.ConfigurationCacheService;
import org.apache.pulsar.broker.resources.PulsarResources;
import org.apache.pulsar.common.conf.InternalConfigurationData;
import org.apache.pulsar.common.util.SimpleTextOutputStream;
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/dlog/DLInputStream.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/dlog/DLInputStream.java
index 10acb54..27af304 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/dlog/DLInputStream.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/dlog/DLInputStream.java
@@ -40,10 +40,8 @@ public class DLInputStream extends InputStream {
// Cache the input stream for a log record.
private static class LogRecordWithInputStream {
private final InputStream payloadStream;
- private final LogRecordWithDLSN logRecord;
LogRecordWithInputStream(LogRecordWithDLSN logRecord) {
- this.logRecord = logRecord;
this.payloadStream = logRecord.getPayLoadInputStream();
}
@@ -51,15 +49,6 @@ public class DLInputStream extends InputStream {
return payloadStream;
}
- LogRecordWithDLSN getLogRecord() {
- return logRecord;
- }
-
- // The last txid of the log record is the position of the next byte in the stream.
- // Subtract length to get starting offset.
- long getOffset() {
- return logRecord.getTransactionId() - logRecord.getPayload().length;
- }
}
/**
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java
index c7414c2..e531084 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java
@@ -18,7 +18,6 @@
*/
package org.apache.pulsar.functions.worker.rest;
-import com.google.common.annotations.VisibleForTesting;
import io.prometheus.client.jetty.JettyStatisticsCollector;
import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.broker.authentication.AuthenticationService;
@@ -46,8 +45,6 @@ import org.eclipse.jetty.util.ssl.SslContextFactory;
import org.glassfish.jersey.server.ResourceConfig;
import org.glassfish.jersey.servlet.ServletContainer;
-import java.net.BindException;
-import java.net.URI;
import java.util.ArrayList;
import java.util.EnumSet;
import java.util.List;
@@ -69,15 +66,6 @@ public class WorkerServer {
private ServerConnector httpConnector;
private ServerConnector httpsConnector;
- private static String getErrorMessage(Server server, int port, Exception ex) {
- if (ex instanceof BindException) {
- final URI uri = server.getURI();
- return String.format("%s http://%s:%d", ex.getMessage(), uri.getHost(), port);
- }
-
- return ex.getMessage();
- }
-
public WorkerServer(WorkerService workerService, AuthenticationService authenticationService) {
this.workerConfig = workerService.getWorkerConfig();
this.workerService = workerService;
@@ -191,7 +179,6 @@ public class WorkerServer {
return contextHandler;
}
- @VisibleForTesting
public void stop() {
if (this.server != null) {
try {
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
index c1bc996..e8d67a5 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java
@@ -267,10 +267,7 @@ public abstract class ComponentImpl implements Component<PulsarWorkerService> {
if (workerService == null) {
return false;
}
- if (!workerService.isInitialized()) {
- return false;
- }
- return true;
+ return workerService.isInitialized();
}
PackageLocationMetaData.Builder getFunctionPackageLocation(final FunctionMetaData functionMetaData,
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
index 8c35851..b00846d 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java
@@ -32,7 +32,6 @@ import java.net.URI;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
-import java.util.Arrays;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;
@@ -64,7 +63,6 @@ import org.apache.pulsar.functions.worker.FunctionMetaDataManager;
import org.apache.pulsar.functions.worker.PulsarWorkerService;
import org.apache.pulsar.functions.worker.WorkerUtils;
import org.apache.pulsar.functions.worker.service.api.Functions;
-import org.apache.pulsar.packages.management.core.common.PackageType;
import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
@Slf4j
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java
index bbb1680..ab69ab9 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java
@@ -30,7 +30,6 @@ import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;
@@ -64,7 +63,6 @@ import org.apache.pulsar.functions.worker.FunctionMetaDataManager;
import org.apache.pulsar.functions.worker.PulsarWorkerService;
import org.apache.pulsar.functions.worker.WorkerUtils;
import org.apache.pulsar.functions.worker.service.api.Sinks;
-import org.apache.pulsar.packages.management.core.common.PackageType;
import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
@Slf4j
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourcesImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourcesImpl.java
index 82a818d..df2dca8 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourcesImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourcesImpl.java
@@ -30,7 +30,6 @@ import java.io.IOException;
import java.io.InputStream;
import java.net.URI;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collection;
import java.util.LinkedList;
import java.util.List;
@@ -64,7 +63,6 @@ import org.apache.pulsar.functions.worker.FunctionMetaDataManager;
import org.apache.pulsar.functions.worker.PulsarWorkerService;
import org.apache.pulsar.functions.worker.WorkerUtils;
import org.apache.pulsar.functions.worker.service.api.Sources;
-import org.apache.pulsar.packages.management.core.common.PackageType;
import org.glassfish.jersey.media.multipart.FormDataContentDisposition;
@Slf4j
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java
index f32f6d1..6c2180c 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/WorkerImpl.java
@@ -19,7 +19,6 @@
package org.apache.pulsar.functions.worker.rest.api;
import lombok.extern.slf4j.Slf4j;
-import lombok.val;
import org.apache.pulsar.client.admin.LongRunningProcessStatus;
import org.apache.pulsar.common.functions.WorkerInfo;
import org.apache.pulsar.common.io.ConnectorDefinition;
@@ -76,10 +75,7 @@ public class WorkerImpl implements Workers<PulsarWorkerService> {
if (workerService == null) {
return false;
}
- if (!workerService.isInitialized()) {
- return false;
- }
- return true;
+ return workerService.isInitialized();
}
@Override
diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceWithClassLoader.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceWithClassLoader.java
index 9439d72..6959616 100644
--- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceWithClassLoader.java
+++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/service/WorkerServiceWithClassLoader.java
@@ -25,7 +25,6 @@ import lombok.extern.slf4j.Slf4j;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.authentication.AuthenticationService;
import org.apache.pulsar.broker.authorization.AuthorizationService;
-import org.apache.pulsar.broker.cache.ConfigurationCacheService;
import org.apache.pulsar.broker.resources.PulsarResources;
import org.apache.pulsar.common.conf.InternalConfigurationData;
import org.apache.pulsar.common.nar.NarClassLoader;
@@ -38,7 +37,6 @@ import org.apache.pulsar.functions.worker.service.api.FunctionsV2;
import org.apache.pulsar.functions.worker.service.api.Sinks;
import org.apache.pulsar.functions.worker.service.api.Sources;
import org.apache.pulsar.functions.worker.service.api.Workers;
-import org.apache.pulsar.zookeeper.ZooKeeperCache;
/**
* A worker service with its classloader.
diff --git a/pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionMetaDataManagerTest.java b/pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionMetaDataManagerTest.java
index e5221bd..f7d133d 100644
--- a/pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionMetaDataManagerTest.java
+++ b/pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/FunctionMetaDataManagerTest.java
@@ -299,7 +299,7 @@ public class FunctionMetaDataManagerTest {
mockPulsarClient(), ErrorNotifier.getDefaultImpl()));
doReturn(true).when(functionMetaDataManager).processUpdate(any(Function.FunctionMetaData.class));
- doReturn(true).when(functionMetaDataManager).proccessDeregister(any(Function.FunctionMetaData.class));
+ doReturn(true).when(functionMetaDataManager).processDeregister(any(Function.FunctionMetaData.class));
Request.ServiceRequest serviceRequest
= Request.ServiceRequest.newBuilder().setServiceRequestType(
@@ -324,9 +324,9 @@ public class FunctionMetaDataManagerTest {
doReturn(serviceRequest.toByteArray()).when(msg).getData();
functionMetaDataManager.processMetaDataTopicMessage(msg);
- verify(functionMetaDataManager, times(1)).proccessDeregister(
+ verify(functionMetaDataManager, times(1)).processDeregister(
any(Function.FunctionMetaData.class));
- verify(functionMetaDataManager).proccessDeregister(serviceRequest.getFunctionMetaData());
+ verify(functionMetaDataManager).processDeregister(serviceRequest.getFunctionMetaData());
}
@Test
@@ -393,7 +393,7 @@ public class FunctionMetaDataManagerTest {
.setFunctionDetails(Function.FunctionDetails.newBuilder().setName("func-1")
.setNamespace("namespace-1").setTenant("tenant-1")).build();
- Assert.assertFalse(functionMetaDataManager.proccessDeregister(m1));
+ Assert.assertFalse(functionMetaDataManager.processDeregister(m1));
verify(functionMetaDataManager, times(0))
.setFunctionMetaData(any(Function.FunctionMetaData.class));
verify(schedulerManager, times(0)).schedule();
@@ -411,7 +411,7 @@ public class FunctionMetaDataManagerTest {
// outdated delete request
try {
- functionMetaDataManager.proccessDeregister(m1);
+ functionMetaDataManager.processDeregister(m1);
Assert.assertTrue(false);
} catch (IllegalArgumentException e) {
Assert.assertEquals(e.getMessage(), "Delete request ignored because it is out of date. Please try again.");
@@ -426,7 +426,7 @@ public class FunctionMetaDataManagerTest {
// delete now
m1 = m1.toBuilder().setVersion(2).build();
- Assert.assertTrue(functionMetaDataManager.proccessDeregister(m1));
+ Assert.assertTrue(functionMetaDataManager.processDeregister(m1));
verify(functionMetaDataManager, times(1))
.setFunctionMetaData(any(Function.FunctionMetaData.class));
verify(schedulerManager, times(0)).schedule();