You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by brkishore <gi...@git.apache.org> on 2016/02/02 17:14:44 UTC
[GitHub] trafficserver pull request: TS-4163 changes for ts_lua plugin docu...
GitHub user brkishore opened a pull request:
https://github.com/apache/trafficserver/pull/451
TS-4163 changes for ts_lua plugin document
Context information is deleted for "Hook point constants". And also additional information with the table is added.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brkishore/trafficserver patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #451
----
commit 3973ccc99f4f3dac4bb2d384f7f725a23c954435
Author: Rajendra Kishore B <rb...@att.com>
Date: 2016-02-02T16:11:52Z
TS-4163 changes for ts_lua plugin document
Context information is deleted for "Hook point constants". And also additional information with the table is added.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4163 changes for ts_lua plugin docu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4163 changes for ts_lua plugin docu...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/451#issuecomment-179714610
looks good. just to re-iterate and confirm
TS_LUA_REQUEST_TRANSFORM is not working because of https://issues.apache.org/jira/browse/TS-2825 and TS_LUA_HOOK_SELECT_ALT is not working because of https://issues.apache.org/jira/browse/TS-4128
That sounds correct. Right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4163 changes for ts_lua plugin docu...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/451#issuecomment-180135445
TS_LUA_REQUEST_TRANSFORM - it only worked on request body. That means for POST method. Can you try it out and see if you see the problem mentioned in TS-2825?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4163 changes for ts_lua plugin docu...
Posted by brkishore <gi...@git.apache.org>.
Github user brkishore commented on the pull request:
https://github.com/apache/trafficserver/pull/451#issuecomment-180024520
TS_LUA_REQUEST_TRANSFORM : We have tried just GET (and PURGE) method. During the testing of this method, request transform hook call back function is not executed. This is what we observed. We have not tested the POST method.
TS_LUA_HOOK_SELECT_ALT: If we register the hook in do_remap(), the callback function does not get executed (no core dumps observed). However, if the global hook method (do_global_select_alt()) is implemented, it gets core dump'ed as mentioned the Jira (TS-4128) ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---