Re: [PR] [improve][client] Support multi-topic messageId deserialization to ack messages [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on PR #19944:
URL: https://github.com/apache/pulsar/pull/19944#issuecomment-6356613067

   Thanks @rdhabalia, and sorry this sat so long. Since this PR, PIP-224 added `TopicMessageId.create(topic, MessageId.fromByteArray(bytes))` as the supported way to ack a stored id on a multi-topic consumer. The V5 client's `MessageId` now carries its parent topic through `toByteArray`/`fromByteArray`, so it covers this case directly. Putting the topic into `MessageIdData` would be a wire-protocol change and needs a PIP. Also, the current diff drops the batch index for batched ids. I'm closing this as part of the backlog triage. If you'd still like the v4 serialized form to carry the topic, a PIP on dev@ is the way to go, and I'd be happy to review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org