[GitHub] [maven-fluido-skin] slawekjaranowski commented on pull request #39: [MSKINS-188] improve maven logo

[GitBox <gi...@apache.org>]

slawekjaranowski commented on PR #39:
URL: https://github.com/apache/maven-fluido-skin/pull/39#issuecomment-1165911283

   > The reason for replacement is the original is quite low resolution, picking a higher resolution image means it will scale down for smaller systems while looking good on 4K monitors as well. I lack a 4k monitor so I've kept it simple and used the original image.
   > 
   > I could create a couple different resolution images and then write CSS to set an element background image on a span element which I make window width dependent but the rationale there is to speed dial up style connections from loading the page.
   > 
   > The element itself is within a span which means a delay in loading won't affect page loading and should get alt text which would be displayed if there is an issue loading the image. Hence the KISS
   
   I have display with resolution 3072 × 1920 and powered by logo have effective resolution 116 x 116
   So is scaled from 2450 × 2450 -> 116 x 116
   
   I only think if we really need so big input image? I'm not expert on this subject.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org