You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2025/02/26 18:31:47 UTC

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22551


Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................

IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

The custom cluster workload management tests occaisonally fail with
query not found errors. These failures are very few and far between
but still cause test flakiness.

This patch adds retries into the common assertion functions to ensure
that a slightly slower than normal workload management insert dml
does not cause test failures.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
---
M tests/util/workload_management.py
1 file changed, 42 insertions(+), 19 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/22551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22551

to look at the new patch set (#2).

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................

IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

The custom cluster workload management tests occasionally fail with
query not found errors. These failures are very few and far between
but still cause test flakiness.

This patch adds retries into the common assertion functions to ensure
that a slightly slower than normal workload management insert dml
does not cause test failures.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
---
M tests/util/workload_management.py
1 file changed, 42 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/22551/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................

IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

The custom cluster workload management tests occasionally fail with
query not found errors. These failures are very few and far between
but still cause test flakiness.

This patch adds retries into the common assertion functions to ensure
that a slightly slower than normal workload management insert dml
does not cause test failures.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Reviewed-on: http://gerrit.cloudera.org:8080/22551
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/util/workload_management.py
1 file changed, 47 insertions(+), 19 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@74
PS3, Line 74: 30
Make this a constant after L35.


http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@84
PS3, Line 84: len(sql_results.data) == 1
There should be no duplicate, but just in case, please assert that len(sql_results.data) is indeed 1

    if sql_results.success and sql_results.data:
      assert len(sql_results.data) == 1
      success = True
      break

Same comment for L704.



-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:17:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@74
PS3, Line 74: 
> Make this a constant after L35.
Done


http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@84
PS3, Line 84: option("MAX_ROW_SIZE", max
> There should be no duplicate, but just in case, please assert that len(sql_
The sql could return 0 results though if the query is not yet available.  Thus why the check len(sql_results.data) == 1 exists before declaring success.



-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:32:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

Looks good to me.

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22551/3/tests/util/workload_management.py@84
PS3, Line 84: option("MAX_ROW_SIZE", max
> The sql could return 0 results though if the query is not yet available.  T
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:44:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18399/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:58:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11520/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:49:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18397/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:10:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22551

to look at the new patch set (#4).

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................

IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

The custom cluster workload management tests occasionally fail with
query not found errors. These failures are very few and far between
but still cause test flakiness.

This patch adds retries into the common assertion functions to ensure
that a slightly slower than normal workload management insert dml
does not cause test failures.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
---
M tests/util/workload_management.py
1 file changed, 47 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/22551/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 04:18:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22551

to look at the new patch set (#3).

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................

IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

The custom cluster workload management tests occasionally fail with
query not found errors. These failures are very few and far between
but still cause test flakiness.

This patch adds retries into the common assertion functions to ensure
that a slightly slower than normal workload management insert dml
does not cause test failures.

Testing accomplished by the following test suites passing locally:
  * tests/custom_cluster/test_query_live.py
  * tests/custom_cluster/test_query_log.py
  * tests/custom_cluster/test_workload_mgmt_init.py
  * tests/custom_cluster/test_workload_mgmt_sql_details.py

Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
---
M tests/util/workload_management.py
1 file changed, 44 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/22551/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 5
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:49:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py@73
PS2, Line 73:   for cntr in range(3):
> You can sleep(1) and loop until timeout reached, like
Good idea.  Also made the change in the other for loop in assert_csv_col.


http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py@88
PS2, Line 88: 3000
> This is 3000s?
I meant to sleep for 3 seconds and forgot python's sleep takes seconds as its input.



-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 21:50:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18389/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 18:59:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22551 )

Change subject: IMPALA-13710: Fix Flaky Workload Management Custom Cluster Tests
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py@73
PS2, Line 73:   for cntr in range(3):
You can sleep(1) and loop until timeout reached, like
https://github.com/apache/impala/blob/796c25fc57e5bd37dadd7f79fb79044e56d18c36/tests/beeswax/impala_beeswax.py#L322


http://gerrit.cloudera.org:8080/#/c/22551/2/tests/util/workload_management.py@88
PS2, Line 88: 3000
This is 3000s?



-- 
To view, visit http://gerrit.cloudera.org:8080/22551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38dad4819190fa44ca2933be9907d7f1273621e3
Gerrit-Change-Number: 22551
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 19:06:39 +0000
Gerrit-HasComments: Yes