You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/07 12:45:00 UTC
[jira] [Work logged] (BEAM-5620) Some tests use assertItemsEqual
method, not available in Python 3
[ https://issues.apache.org/jira/browse/BEAM-5620?focusedWorklogId=152065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152065 ]
ASF GitHub Bot logged work on BEAM-5620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/18 12:44
Start Date: 07/Oct/18 12:44
Worklog Time Spent: 10m
Work Description: Fematich opened a new pull request #6599: [BEAM-5620] rename assertItemsEqual to assertCounEqual for PY3 compatibility
URL: https://github.com/apache/beam/pull/6599
Replaced all `assertItemsEqual` by assigning it to `assertCountEqual` on Python 2, as discussed in [BEAM-5620] and illustrated in https://github.com/apache/beam/blob/c34c367f5da6f9bef8a46471195470923a201af9/sdks/python/apache_beam/coders/coders_test_common.py#L61
I have added `def setUpClass(cls)` if it wasn't available (only `setUp` was in most cases), so that it shouldn't be rerun for every test of the class.
This is is part of a series of PRs with goal to make Apache Beam PY3 compatible. The proposal with the outlined approach has been documented here: https://s.apache.org/beam-python-3
@tvalentyn @manuzhang @charlesccychen @aaltay @splovyt @Juta
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152065)
Time Spent: 10m
Remaining Estimate: 0h
> Some tests use assertItemsEqual method, not available in Python 3
> -----------------------------------------------------------------
>
> Key: BEAM-5620
> URL: https://issues.apache.org/jira/browse/BEAM-5620
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> See: https://github.com/apache/beam/search?q=assertItemsEqual&unscoped_q=assertItemsEqual
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)