[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #13640: [Feature][Metrics] Tag workflow related metrics with process definition code (workflow id)

["ruanwenjun (via GitHub)" <gi...@apache.org>]

ruanwenjun commented on code in PR #13640:
URL: https://github.com/apache/dolphinscheduler/pull/13640#discussion_r1127410387


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/metrics/ProcessInstanceMetrics.java:
##########
@@ -82,8 +78,26 @@ public synchronized void registerProcessInstanceResubmitGauge(Supplier<Number> f
                 .register(Metrics.globalRegistry);
     }
 
-    public void incProcessInstanceByState(final String state) {
-        processInstanceCounters.get(state).increment();
+    public void incProcessInstanceByStateAndProcessDefinitionCode(final String state,
+                                                                  final String processDefinitionCode) {

Review Comment:
   Can we use workflowDefinitionName rather than `code` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org