You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2003/08/08 11:04:52 UTC

Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c

On Thu, Aug 07, 2003 at 11:57:12PM -0000, striker@apache.org wrote:
>...
>   +++ ssl_engine_kernel.c	7 Aug 2003 23:57:11 -0000	1.98
>   @@ -880,6 +880,8 @@
>                password = auth_line;
>    
>                if ((username[0] == '/') && strEQ(password, "password")) {
>   +                ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
>   +                 "Encountered FakeBasicAuth spoof: %s", username);
>                    return HTTP_FORBIDDEN;
>                }

Hmm. You have a request_rec there. How about:

   ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
                 "Encountered FakeBasicAuth spoof: %s", username);

Providing the request means that you get more information in the error_log.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c

Posted by Sander Striker <st...@apache.org>.
> From: Jeff Trawick [mailto:trawick@attglobal.net]
> Sent: Friday, August 08, 2003 11:17 AM

> Sander Striker wrote:
> 
> >>Hmm. You have a request_rec there. How about:
> >>
> >>   ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> >>                 "Encountered FakeBasicAuth spoof: %s", username);
> >>
> >>Providing the request means that you get more information in the error_log.
> > 
> > 
> > Duh.  Thx,
> 
> Plz assume my +1 for APACHE_2_0_BRANCH is for the forthcoming rerror 
> version :)

*grin* Thanks Jeff.


Sander

Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c

Posted by Jeff Trawick <tr...@attglobal.net>.
Sander Striker wrote:

>>Hmm. You have a request_rec there. How about:
>>
>>   ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
>>                 "Encountered FakeBasicAuth spoof: %s", username);
>>
>>Providing the request means that you get more information in the error_log.
> 
> 
> Duh.  Thx,

Plz assume my +1 for APACHE_2_0_BRANCH is for the forthcoming rerror 
version :)



RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_kernel.c

Posted by Sander Striker <st...@apache.org>.
> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Friday, August 08, 2003 11:05 AM

> On Thu, Aug 07, 2003 at 11:57:12PM -0000, striker@apache.org wrote:
> >...
> >   +++ ssl_engine_kernel.c	7 Aug 2003 23:57:11 -0000	1.98
> >   @@ -880,6 +880,8 @@
> >                password = auth_line;
> >    
> >                if ((username[0] == '/') && strEQ(password, "password")) {
> >   +                ap_log_error(APLOG_MARK, APLOG_ERR, 0, r->server,
> >   +                 "Encountered FakeBasicAuth spoof: %s", username);
> >                    return HTTP_FORBIDDEN;
> >                }
> 
> Hmm. You have a request_rec there. How about:
> 
>    ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
>                  "Encountered FakeBasicAuth spoof: %s", username);
> 
> Providing the request means that you get more information in the error_log.

Duh.  Thx,


Sander.