You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/18 14:23:34 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3980: Fix
String.format unused/misused arguments
GabrielBrascher opened a new pull request #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980
## Description
Simple log fix. I have found out a few log messages that holds unused/misused arguments on their respective String.format building.
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604932902
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604900407
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-603802857
@DaanHoogland @andrijapanicsb should I aim this PR to 4.13 or let's leave it for later? Not critical but it still messing with a few log messages.
You are the RM for 4.13.1/4.14.0, so I leave such decision to you guys ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604024689
@DaanHoogland agreed, this one is not critical and can wait without any problem. Let's first focus on blockers for master and 4.13.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604900926
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604911518
Packaging result: ✔centos7 ✔debian. JID-1099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604932464
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request
#3980: Fix String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#discussion_r394385294
##########
File path: plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BareMetalDiscoverer.java
##########
@@ -205,7 +205,7 @@ public boolean stop() {
zone.setDhcpProvider(Network.Provider.ExternalDhcpServer.getName());
_dcDao.update(zone.getId(), zone);
- s_logger.debug(String.format("Discover Bare Metal host successfully(ip=%1$s, username=%2$s, password=%3%s," +
+ s_logger.debug(String.format("Discover Bare Metal host successfully(ip=%1$s, username=%2$s, password=%3$s," +
"cpuNum=%4$s, cpuCapacity-%5$s, memCapacity=%6$s)", ipmiIp, username, "******", cpuNum, cpuCapacity, memCapacity));
Review comment:
WIthout the fix it will print something as:
```
Discover Bare Metal host successfully(ip=ipmiIp, username=username, password= %s,cpuNum=cpuNum, cpuCapacity-cpuCapacity, memCapacity=memCapacity)
```
WIth the fix:
```
Discover Bare Metal host successfully(ip=ipmiIp, username=username, password=******,cpuNum=cpuNum, cpuCapacity-cpuCapacity, memCapacity=memCapacity)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-605387706
<b>Trillian test result (tid-1330)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58457 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3980-t1330-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 53 look OK, 24 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_UpdateConfigParamWithScope | `Error` | 0.06 | test_global_settings.py
test_02_vpc_privategw_static_routes | `Failure` | 120.55 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 120.63 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 174.61 | test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.14 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.02 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.06 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py
test_09_destroy_ssvm | `Failure` | 0.02 | test_ssvm.py
test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.31 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.34 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.30 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.33 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.16 | test_templates.py
test_03_deploy_vm_wrong_checksum | `Error` | 1.21 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.39 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration | `Error` | 11.25 | test_vm_life_cycle.py
test_15_secured_to_nonsecured_vm_migration | `Error` | 73.89 | test_vm_life_cycle.py
test_16_nonsecured_to_secured_vm_migration | `Error` | 1.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 1.54 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 163.18 | test_host_maintenance.py
test_disable_oobm_ha_state_ineligible | `Error` | 1511.36 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3980: Fix
String.format unused/misused arguments
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3980: Fix String.format unused/misused arguments
URL: https://github.com/apache/cloudstack/pull/3980#issuecomment-604022841
@GabrielBrascher if it need sto go in both 4.13, but it is not critical and we really need to get the critical stuff done, we can create .-releases for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services