You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by pm...@apache.org on 2018/07/25 18:19:21 UTC
samza git commit: SAMZA-1677: Make httpcore and httpclient
dependencies consistent
Repository: samza
Updated Branches:
refs/heads/master de5d92e51 -> c98d7b0d8
SAMZA-1677: Make httpcore and httpclient dependencies consistent
Samza currently depends on httpclient 4.5.2 and httpcore 4.4.5. However, httpclient 4.5.2 also has a direct dependency on httpcore 4.4.4, which is not backwards compatible with httpcore 4.4.5 since some classes were removed (e.g. ThreadSafe/NotThreadSafe annotation classes).
Although this does not currently cause any direct build problems, there may be cases where this conflict introduces transitive dependency conflicts. In addition, this inconsistency can cause confusion in future development if those libraries need to be used.
Author: Cameron Lee <ca...@linkedin.com>
Reviewers: Jagadish Venkatraman <vj...@gmail.com>, Shanthoosh Venkatraman <sv...@linkedin.com>
Closes #534 from cameronlee314/httpcore
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/c98d7b0d
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/c98d7b0d
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/c98d7b0d
Branch: refs/heads/master
Commit: c98d7b0d88f3b04faf4ae3fd0151d26e24534724
Parents: de5d92e
Author: Cameron Lee <ca...@linkedin.com>
Authored: Wed Jul 25 11:19:11 2018 -0700
Committer: Prateek Maheshwari <pm...@apache.org>
Committed: Wed Jul 25 11:19:11 2018 -0700
----------------------------------------------------------------------
build.gradle | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/c98d7b0d/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index 2e90604..e4583e4 100644
--- a/build.gradle
+++ b/build.gradle
@@ -237,7 +237,6 @@ project(':samza-aws') {
compile project(":samza-core_$scalaVersion")
compile "org.slf4j:slf4j-api:$slf4jVersion"
runtime "org.apache.httpcomponents:httpclient:4.5.2"
- runtime "org.apache.httpcomponents:httpcore:4.4.5"
testCompile "junit:junit:$junitVersion"
testCompile "org.mockito:mockito-all:$mockitoVersion"
}