Re: [PR] [MRESOLVER-554] Split thread counts for up and downstream ops [maven-resolver]

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #489:
URL: https://github.com/apache/maven-resolver/pull/489#discussion_r1585969952


##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -97,15 +100,17 @@ final class BasicRepositoryConnector implements RepositoryConnector {
 
     private final ChecksumPolicyProvider checksumPolicyProvider;
 
-    private final int maxThreads;
+    private final int maxDownstreamThreads;
+
+    private final int maxUpstreamThreads;
 
     private final boolean smartChecksums;
 
     private final boolean parallelPut;
 
     private final boolean persistedChecksums;
 
-    private Executor executor;
+    private final ConcurrentHashMap<Boolean, Executor> executors;

Review Comment:
   Just a remark. An Enum would read better than just a boolean...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org