You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mcgilman <gi...@git.apache.org> on 2016/07/29 14:38:36 UTC
[GitHub] nifi pull request #745: Enabling Play/Stop buttons in palette more liberally
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/745
Enabling Play/Stop buttons in palette more liberally
NIFI-2401:
- Returning the enabled state of play and stop buttons in the palette. Allowing the user to always press if they have permissions to modify the selection or if no selection.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI-2401
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #745
----
commit b6807751945744749a6c8336dc6b67a74cff28cd
Author: Matt Gilman <ma...@gmail.com>
Date: 2016-07-29T14:36:25Z
NIFI-2401:
- Returning the enabled state of play and stop buttons in the palette. Allowing the user to always press if they have permissions to modify the selection.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/745
Actually I was trying to start the group with nothing selected. This is a change to the client side but I think there just needs to be a filter server side to just exclude invalid processors from being started (like disabled processors are).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/745
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/745
I don't think changing it to "canModify" is the right fix. If I have on the graph multiple processors I want to run and there happens to one or more invalid processors there too it will come back with an error saying the processors are not in a valid state when I try to run.
I believe the way 0.x worked is it would ignore invalid processors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/745
Ah ok. Will update. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #745: Enabling Play/Stop buttons in palette more liberally
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/745
+1
Visually verified code, and ran a contrib check build. In 3 node secure cluster and standalone instance tested various combinations of valid, invalid and disabled components to see the result of hitting start/stop. All functioned as expected. Thanks @mcgilman, I will merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #745: Enabling Play/Stop buttons in palette more liberally
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/745
Invalid processors are only ignored when your starting a group (there is no selection). This is how it works in 0.x and 1.x. When there is something selected this is not the case. I believe the behavior is consistent with only the addition in 1.x to ensure you have permissions to modify the entire selection. In 0.x the play and stop buttons are always enabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---