You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Henry Saputra <hs...@apache.org> on 2012/06/19 03:19:42 UTC
Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods start
with is as accessor to properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5411/
-----------------------------------------------------------
Review request for shindig.
Description
-------
See https://issues.apache.org/jira/browse/SHINDIG-1807
This addresses bug SHINDIG-1807.
https://issues.apache.org/jira/browse/SHINDIG-1807
Diffs
-----
Diff: https://reviews.apache.org/r/5411/diff/
Testing
-------
Updated the broken unit tests.
Thanks,
Henry Saputra
Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods
start with is as accessor to properties
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5411/#review8384
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 19, 2012, 1:32 a.m., Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5411/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:32 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> This addresses bug SHINDIG-1807.
> https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> Diffs
> -----
>
> trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1351453
>
> Diff: https://reviews.apache.org/r/5411/diff/
>
>
> Testing
> -------
>
> Updated the broken unit tests.
>
>
> Thanks,
>
> Henry Saputra
>
>
Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods
start with is as accessor to properties
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5411/#review8386
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On June 19, 2012, 1:32 a.m., Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5411/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:32 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> This addresses bug SHINDIG-1807.
> https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> Diffs
> -----
>
> trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1351453
>
> Diff: https://reviews.apache.org/r/5411/diff/
>
>
> Testing
> -------
>
> Updated the broken unit tests.
>
>
> Thanks,
>
> Henry Saputra
>
>
Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods
start with is as accessor to properties
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5411/#review8383
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On June 19, 2012, 1:32 a.m., Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5411/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 1:32 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> This addresses bug SHINDIG-1807.
> https://issues.apache.org/jira/browse/SHINDIG-1807
>
>
> Diffs
> -----
>
> trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1351453
> trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1351453
>
> Diff: https://reviews.apache.org/r/5411/diff/
>
>
> Testing
> -------
>
> Updated the broken unit tests.
>
>
> Thanks,
>
> Henry Saputra
>
>
Re: Review Request: SHINDIG-1807 Fix the JsonUtil to also consider methods
start with is as accessor to properties
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5411/
-----------------------------------------------------------
(Updated June 19, 2012, 1:32 a.m.)
Review request for shindig.
Description
-------
See https://issues.apache.org/jira/browse/SHINDIG-1807
This addresses bug SHINDIG-1807.
https://issues.apache.org/jira/browse/SHINDIG-1807
Diffs (updated)
-----
trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java 1351453
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json 1351453
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1351453
trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1351453
Diff: https://reviews.apache.org/r/5411/diff/
Testing
-------
Updated the broken unit tests.
Thanks,
Henry Saputra