You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/04/19 23:08:20 UTC
Review Request 66725: Improved error message in the fetcher.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66725/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Included error message from `mkdir` when
returning error.
Diffs
-----
src/launcher/fetcher.cpp 8a8d7c3311c6d282648940bc4440f4c6d9d5e918
Diff: https://reviews.apache.org/r/66725/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66725: Improved error message in the fetcher.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66725/#review201595
-----------------------------------------------------------
PASS: Mesos patch 66725 was successfully built and tested.
Reviews applied: `['66725']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66725
- Mesos Reviewbot Windows
On April 19, 2018, 4:08 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66725/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 4:08 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included error message from `mkdir` when
> returning error.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 8a8d7c3311c6d282648940bc4440f4c6d9d5e918
>
>
> Diff: https://reviews.apache.org/r/66725/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66725: Improved error message in the fetcher.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66725/#review201720
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On April 19, 2018, 4:08 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66725/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 4:08 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included error message from `mkdir` when
> returning error.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 8a8d7c3311c6d282648940bc4440f4c6d9d5e918
>
>
> Diff: https://reviews.apache.org/r/66725/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66725: Improved error message in the fetcher.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66725/#review201645
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66725]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 19, 2018, 4:08 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66725/
> -----------------------------------------------------------
>
> (Updated April 19, 2018, 4:08 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Included error message from `mkdir` when
> returning error.
>
>
> Diffs
> -----
>
> src/launcher/fetcher.cpp 8a8d7c3311c6d282648940bc4440f4c6d9d5e918
>
>
> Diff: https://reviews.apache.org/r/66725/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>