You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:35:22 UTC

[GitHub] [gobblin] aplex opened a new pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

aplex opened a new pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320


   Previously, checkstyle was configured to check only a small subset of
   things, and imports were not one of them. As a result, reviewers spend
   their time commenting on code style, when it can be fully verified
   automatically by CI job.
   
   We enable unused/redundant import checks, and fix existing issues, so
   that the build could complete successfully.
   
   The only relevant change is in checkstyle.xml, all other files where
   changed by IntelliJ "optimize imports" function. For most files it
   just removed unused imports, but some of them had imports incorrectly
   ordered, and IntelliJ fixed that as well.
   
   https://issues.apache.org/jira/browse/GOBBLIN-1480
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a25b304) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `3.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   42.82%   -3.68%     
   + Complexity    10041     1931    -8110     
   ============================================
     Files          2041      394    -1647     
     Lines         79349    16870   -62479     
     Branches       8845     2072    -6773     
   ============================================
   - Hits          36898     7225   -29673     
   + Misses        39020     8846   -30174     
   + Partials       3431      799    -2632     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh) | `60.00% <ø> (ø)` | |
   | [...e/gobblin/example/hadoop/HadoopTextFileSource.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1leGFtcGxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2V4YW1wbGUvaGFkb29wL0hhZG9vcFRleHRGaWxlU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...che/gobblin/metastore/DatabaseJobHistoryStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFiYXNlSm9iSGlzdG9yeVN0b3JlLmphdmE=) | `78.26% <ø> (ø)` | |
   | [...obblin/metastore/FileContextBasedFsStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZpbGVDb250ZXh0QmFzZWRGc1N0YXRlU3RvcmUuamF2YQ==) | `0.00% <ø> (ø)` | |
   | ... and [1546 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...a25b304](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter commented on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9044b4c) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `3.63%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   42.86%   -3.64%     
   + Complexity    10041     1929    -8112     
   ============================================
     Files          2041      392    -1649     
     Lines         79349    16849   -62500     
     Branches       8845     2072    -6773     
   ============================================
   - Hits          36898     7223   -29675     
   + Misses        39020     8824   -30196     
   + Partials       3431      802    -2629     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh) | `60.00% <ø> (ø)` | |
   | [...e/gobblin/example/hadoop/HadoopTextFileSource.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1leGFtcGxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2V4YW1wbGUvaGFkb29wL0hhZG9vcFRleHRGaWxlU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...che/gobblin/metastore/DatabaseJobHistoryStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFiYXNlSm9iSGlzdG9yeVN0b3JlLmphdmE=) | `78.26% <ø> (ø)` | |
   | [...obblin/metastore/FileContextBasedFsStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZpbGVDb250ZXh0QmFzZWRGc1N0YXRlU3RvcmUuamF2YQ==) | `0.00% <ø> (ø)` | |
   | ... and [1541 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...9044b4c](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a25b304) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `4.25%`.
   > The diff coverage is `64.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   42.24%   -4.26%     
   + Complexity    10041     4494    -5547     
   ============================================
     Files          2041     1021    -1020     
     Lines         79349    40435   -38914     
     Branches       8845     4509    -4336     
   ============================================
   - Hits          36898    17083   -19815     
   + Misses        39020    21654   -17366     
   + Partials       3431     1698    -1733     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/password/PasswordManager.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcGFzc3dvcmQvUGFzc3dvcmRNYW5hZ2VyLmphdmE=) | `28.28% <ø> (ø)` | |
   | [...org/apache/gobblin/typedconfig/ConstraintUtil.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZWRjb25maWcvQ29uc3RyYWludFV0aWwuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh) | `60.00% <ø> (ø)` | |
   | ... and [1001 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...a25b304](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b2dea) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `3.66%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   42.83%   -3.67%     
   + Complexity    10041     1931    -8110     
   ============================================
     Files          2041      394    -1647     
     Lines         79349    16870   -62479     
     Branches       8845     2072    -6773     
   ============================================
   - Hits          36898     7226   -29672     
   + Misses        39020     8846   -30174     
   + Partials       3431      798    -2633     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh) | `60.00% <ø> (ø)` | |
   | [...e/gobblin/example/hadoop/HadoopTextFileSource.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1leGFtcGxlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2V4YW1wbGUvaGFkb29wL0hhZG9vcFRleHRGaWxlU291cmNlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...che/gobblin/metastore/DatabaseJobHistoryStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0RhdGFiYXNlSm9iSGlzdG9yeVN0b3JlLmphdmE=) | `78.26% <ø> (ø)` | |
   | [...obblin/metastore/FileContextBasedFsStateStore.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL0ZpbGVDb250ZXh0QmFzZWRGc1N0YXRlU3RvcmUuamF2YQ==) | `0.00% <ø> (ø)` | |
   | ... and [1547 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...39b2dea](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] autumnust merged pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
autumnust merged pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] sv2000 commented on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-872563720


   @aplex Thanks for this clean up PR! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a25b304) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `0.18%`.
   > The diff coverage is `76.47%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   46.32%   -0.19%     
   + Complexity    10041     3047    -6994     
   ============================================
     Files          2041      642    -1399     
     Lines         79349    25000   -54349     
     Branches       8845     2985    -5860     
   ============================================
   - Hits          36898    11580   -25318     
   + Misses        39020    12172   -26848     
   + Partials       3431     1248    -2183     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/password/PasswordManager.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcGFzc3dvcmQvUGFzc3dvcmRNYW5hZ2VyLmphdmE=) | `28.28% <ø> (ø)` | |
   | [...org/apache/gobblin/typedconfig/ConstraintUtil.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZWRjb25maWcvQ29uc3RyYWludFV0aWwuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../store/hdfs/SimpleLocalHDFSConfigStoreFactory.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb25maWctbWFuYWdlbWVudC9nb2JibGluLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbmZpZy9zdG9yZS9oZGZzL1NpbXBsZUxvY2FsSERGU0NvbmZpZ1N0b3JlRmFjdG9yeS5qYXZh) | `60.00% <ø> (ø)` | |
   | ... and [1329 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...a25b304](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter edited a comment on pull request #3320: [GOBBLIN-1480] Cleanup unused imports and enable checkstyle for them

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3320:
URL: https://github.com/apache/gobblin/pull/3320#issuecomment-867154244


   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3320](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a25b304) into [master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf37c76) will **decrease** coverage by `0.08%`.
   > The diff coverage is `63.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/gobblin/pull/3320/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3320      +/-   ##
   ============================================
   - Coverage     46.50%   46.41%   -0.09%     
   + Complexity    10041    10012      -29     
   ============================================
     Files          2041     2033       -8     
     Lines         79349    79060     -289     
     Branches       8845     8838       -7     
   ============================================
   - Hits          36898    36697     -201     
   + Misses        39020    38957      -63     
   + Partials       3431     3406      -25     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/java/org/apache/gobblin/cli/CliTablePrinter.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hZG1pbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jbGkvQ2xpVGFibGVQcmludGVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/password/PasswordManager.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcGFzc3dvcmQvUGFzc3dvcmRNYW5hZ2VyLmphdmE=) | `28.28% <ø> (ø)` | |
   | [...org/apache/gobblin/typedconfig/ConstraintUtil.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZWRjb25maWcvQ29uc3RyYWludFV0aWwuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0.00% <ø> (ø)` | |
   | [.../gobblin/cluster/GobblinClusterMetricTagNames.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNZXRyaWNUYWdOYW1lcy5qYXZh) | `0.00% <ø> (ø)` | |
   | [...pache/gobblin/cluster/GobblinHelixTaskMetrics.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza01ldHJpY3MuamF2YQ==) | `97.61% <ø> (ø)` | |
   | [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...lin/cluster/event/CancelJobConfigArrivalEvent.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2FuY2VsSm9iQ29uZmlnQXJyaXZhbEV2ZW50LmphdmE=) | `0.00% <ø> (ø)` | |
   | [...mpaction/action/CompactionMarkDirectoryAction.java](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25NYXJrRGlyZWN0b3J5QWN0aW9uLmphdmE=) | `46.15% <ø> (ø)` | |
   | ... and [186 more](https://codecov.io/gh/apache/gobblin/pull/3320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e03329...a25b304](https://codecov.io/gh/apache/gobblin/pull/3320?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org