You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2022/09/08 22:13:09 UTC

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18955


Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................

IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

bin/jenkins/all-tests.sh does not run finalize.sh if
bin/bootstrap_development.sh fails. This is inconvenient,
because sometimes Impala can crash during dataload, and
it is useful for finalize.sh to resolve any minidumps.

This changes all-tests.sh to run finalize.sh even if
bootstrap_development.sh fails.

Testing:
 - Ran this on an ARM job that was failing during
   dataload. Finalize ran properly.

Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
---
M bin/jenkins/all-tests.sh
1 file changed, 14 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/18955/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18955 )

Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................


Patch Set 1: Code-Review+2

Carry +1 from Michael


-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 02:42:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18955 )

Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 22:30:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18955 )

Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................


Patch Set 1: Verified+1

Top of stack passed GVO


-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Sep 2022 15:23:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18955 )

Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11320/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Sep 2022 22:28:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18955 )

Change subject: IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails
......................................................................

IMPALA-11569: Run finalize.sh in all-tests.sh even if dataload fails

bin/jenkins/all-tests.sh does not run finalize.sh if
bin/bootstrap_development.sh fails. This is inconvenient,
because sometimes Impala can crash during dataload, and
it is useful for finalize.sh to resolve any minidumps.

This changes all-tests.sh to run finalize.sh even if
bootstrap_development.sh fails.

Testing:
 - Ran this on an ARM job that was failing during
   dataload. Finalize ran properly.

Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Reviewed-on: http://gerrit.cloudera.org:8080/18955
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/jenkins/all-tests.sh
1 file changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Michael Smith: Looks good to me, but someone else must approve
  Wenzhe Zhou: Looks good to me, approved
  Joe McDonnell: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46fcc1d552341607ada9a6c37f6a5fb13be213a5
Gerrit-Change-Number: 18955
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>