You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/11/14 10:56:20 UTC
[GitHub] [carbondata] jackylk commented on a change in pull request #3449:
[CARBONDATA-3578] Make table status file smaller
jackylk commented on a change in pull request #3449: [CARBONDATA-3578] Make table status file smaller
URL: https://github.com/apache/carbondata/pull/3449#discussion_r346247681
##########
File path: core/src/main/java/org/apache/carbondata/core/statusmanager/LoadMetadataDetails.java
##########
@@ -468,4 +482,26 @@ public boolean isCarbonFormat() {
return getFileFormat().equals(FileFormat.COLUMNAR_V3)
|| getFileFormat().equals(FileFormat.ROW_V1);
}
+
+ /**
+ * Before writing table status file, call this to make the metadata smaller.
+ * It checks if fields are default value, then make it null so GSON does not write it
+ */
+ void removeUnnecessaryField() {
+ if (updateDeltaEndTimestamp == null || updateDeltaStartTimestamp.isEmpty()) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services